Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc

Issue 5974006: Convert srpc definitions from using int64 to using PP_Instance, PP_Module, an... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc
===================================================================
--- src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc (revision 4040)
+++ src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc (working copy)
@@ -14,18 +14,16 @@
NaClSrpcRpc* rpc,
NaClSrpcClosure* done,
// inputs
- int64_t module,
+ PP_Module module,
// outputs
- int64_t* resource) {
+ PP_Resource* resource) {
NACL_UNTESTED();
NaClSrpcClosureRunner runner(done);
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
- PP_Resource pp_resource =
- ppapi_proxy::PPBURLRequestInfoInterface()->Create(
- static_cast<PP_Module>(module));
+ *resource =
+ ppapi_proxy::PPBURLRequestInfoInterface()->Create(module);
- *resource = static_cast<int64_t>(pp_resource);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -33,7 +31,7 @@
NaClSrpcRpc* rpc,
NaClSrpcClosure* done,
// inputs
- int64_t resource,
+ PP_Resource resource,
// outputs
int32_t* is_url_request_info) {
NACL_UNTESTED();
@@ -41,8 +39,7 @@
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
PP_Bool pp_is_url_request_info =
- ppapi_proxy::PPBURLRequestInfoInterface()->IsURLRequestInfo(
- static_cast<PP_Resource>(resource));
+ ppapi_proxy::PPBURLRequestInfoInterface()->IsURLRequestInfo(resource);
*is_url_request_info = (pp_is_url_request_info == PP_TRUE);
rpc->result = NACL_SRPC_RESULT_OK;
@@ -52,7 +49,7 @@
NaClSrpcRpc* rpc,
NaClSrpcClosure* done,
// inputs
- int64_t request,
+ PP_Resource request,
int32_t property,
nacl_abi_size_t value_size, char* value_bytes,
// outputs
@@ -68,7 +65,7 @@
PP_Bool pp_success =
ppapi_proxy::PPBURLRequestInfoInterface()->SetProperty(
- static_cast<PP_Resource>(request),
+ request,
static_cast<PP_URLRequestProperty>(property),
value);
@@ -80,7 +77,7 @@
NaClSrpcRpc* rpc,
NaClSrpcClosure* done,
// inputs
- int64_t request,
+ PP_Resource request,
nacl_abi_size_t data_size, char* data_bytes,
// outputs
int32_t* success) {
@@ -90,7 +87,7 @@
PP_Bool pp_success =
ppapi_proxy::PPBURLRequestInfoInterface()->AppendDataToBody(
- static_cast<PP_Resource>(request),
+ request,
static_cast<const char*>(data_bytes),
static_cast<uint32_t>(data_size));
@@ -102,8 +99,8 @@
NaClSrpcRpc* rpc,
NaClSrpcClosure* done,
// inputs
- int64_t request,
- int64_t file_ref,
+ PP_Resource request,
+ PP_Resource file_ref,
int64_t start_offset,
int64_t number_of_bytes,
double expected_last_modified_time,
@@ -115,8 +112,8 @@
PP_Bool pp_success =
ppapi_proxy::PPBURLRequestInfoInterface()->AppendFileToBody(
- static_cast<PP_Resource>(request),
- static_cast<PP_Resource>(file_ref),
+ request,
+ file_ref,
start_offset,
number_of_bytes,
static_cast<PP_Time>(expected_last_modified_time));
Property changes on: src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « src/shared/ppapi_proxy/browser_ppb_rpc_server.cc ('k') | src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698