Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: src/shared/ppapi_proxy/ppb_instance.srpc

Issue 5974006: Convert srpc definitions from using int64 to using PP_Instance, PP_Module, an... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/shared/ppapi_proxy/ppb_instance.srpc
===================================================================
--- src/shared/ppapi_proxy/ppb_instance.srpc (revision 4034)
+++ src/shared/ppapi_proxy/ppb_instance.srpc (working copy)
@@ -8,32 +8,32 @@
'name': 'PpbInstanceRpc',
'rpcs': [
{'name': 'PPB_Instance_GetWindowObject',
- 'inputs': [['instance', 'int64_t'], # PP_Instance
+ 'inputs': [['instance', 'PP_Instance'], # PP_Instance
polina 2010/12/23 21:58:30 # PP_Instance/Resource comments can now be removed
noelallen_use_chromium 2010/12/23 22:23:23 Not sure that makes sense. Would be leave the PP_
polina 2010/12/23 22:33:14 It's up to us whether we want to always comment or
],
'outputs': [['window', 'char[]'], # PP_Var
]
},
{'name': 'PPB_Instance_GetOwnerElementObject',
- 'inputs': [['instance', 'int64_t'], # PP_Instance
+ 'inputs': [['instance', 'PP_Instance'], # PP_Instance
],
'outputs': [['owner', 'char[]'], # PP_Var
]
},
{'name': 'PPB_Instance_BindGraphics',
- 'inputs': [['instance', 'int64_t'], # PP_Instance
- ['graphics_device', 'int64_t'], # PP_Resource
+ 'inputs': [['instance', 'PP_Instance'], # PP_Instance
+ ['graphics_device', 'PP_Resource'], # PP_Resource
],
'outputs': [['success', 'int32_t'], # PP_Bool
polina 2010/12/23 23:41:23 'outputs': [['success', 'PP_Bool'], # PP_Bool
]
},
{'name': 'PPB_Instance_IsFullFrame',
- 'inputs': [['instance', 'int64_t'], # PP_Instance
+ 'inputs': [['instance', 'PP_Instance'], # PP_Instance
],
'outputs': [['is_full_frame', 'int32_t'], # PP_Bool
polina 2010/12/23 23:41:23 'outputs': [['is_full_frame', 'PP_Bool'], # PP_Bo
]
},
{'name': 'PPB_Instance_ExecuteScript',
- 'inputs': [['instance', 'int64_t'], # PP_Instance
+ 'inputs': [['instance', 'PP_Instance'], # PP_Instance
['script', 'char[]' ], # PP_Var
['exception_in', 'char[]'], # PP_Var*
],

Powered by Google App Engine
This is Rietveld 408576698