Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 597393003: NaCl: Update revision in DEPS, r13770 -> r13783 (Closed)

Created:
6 years, 2 months ago by Derek Schuff
Modified:
6 years, 2 months ago
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13759 -> r13783 This pulls in the following Native Client changes: r13760: (mseaborn) untrusted.gypi: Factor out duplicated "--gomadir" option r13761: (mseaborn) Fix mmap() with length > 0xffff0000 to behave consistently on 32/64-bit r13762: (teravest) Support file path metadata for the main nexe. r13763: (teravest) Add CreateNaClDescWithFilePathMetadata fn. r13764: (dschuff) Switch PNaCl lib, include, and translator directories for new layout r13765: (dschuff) Pass naclsdk_validate=0 to scons runs run by main waterfall bots r13768: (dbrazdil) Allowed decrementing program break with sbrk() in MinSFI r13769: (dyen) Added tests for rename functions in irt_ext. r13770: (dyen) Added tests for unlink functions irt_ext. r13771: (dschuff) Update revision for PNaCl r13753->r13769 r13772: (dyen) Added tests for fsync/fdatasync functions in irt_ext. r13773: (petarj) PNaCl: Update libcxx revision in pnacl/COMPONENT_REVISIONS r13774: (dyen) Added tests for file truncation functions in irt_ext. r13775: (sehr) Add Nick Bray and Shyam as owners of the validator r13776: (jvoung) Remember to va_end in callingconv test. r13777: (shyamsundarr) a script to generate a trie from our DFA. r13778: (shyamsundarr) updated version of mseaborn@chromium's old trie code. We will generate r13779: (dschuff) Allow build of host tools with system compiler r13780: (dyen) Added support for supplying futex calls under irt_ext. r13781: (dschuff) Remove archived_frontend test and use gcc build for FYI bots r13782: (dschuff) Clang and binutils for direct to nacl x86_64 r13783: (dschuff) Change prep_nacl_sdk header locations for PNaCl to match new layout r13784: (dschuff) Revert r13723, r13730, r13744 r13785: (dschuff) Revert "untrusted.gypi: Factor out duplicated "--gomadir" option" This also adjusts the SDK header copying script to put the libnacl headers in the new location for PNaCl. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg Committed: https://crrev.com/24cc138c03e5e58dd3cd1536be0bbcdd6bd9ba49 Cr-Commit-Position: refs/heads/master@{#296781}

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove StandardArch from pnacl_component_crx_gen.py #

Patch Set 3 : rebase #

Patch Set 4 : update to 13785 #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +19 lines, -19 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py View 1 2 chunks +2 lines, -9 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Derek Schuff
won't land until after https://codereview.chromium.org/604483002/ does, but wanted to get a jump on the try ...
6 years, 2 months ago (2014-09-24 22:37:31 UTC) #4
Derek Schuff
On 2014/09/24 22:37:31, Derek Schuff wrote: > won't land until after https://codereview.chromium.org/604483002/ does, but > ...
6 years, 2 months ago (2014-09-24 23:36:46 UTC) #5
jvoung (off chromium)
lgtm https://codereview.chromium.org/597393003/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py File ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py (right): https://codereview.chromium.org/597393003/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py#newcode58 ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py:58: def StandardArch(arch): standardarch is now unused https://codereview.chromium.org/597393003/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py#newcode173 ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py:173: ...
6 years, 2 months ago (2014-09-24 23:36:47 UTC) #6
Derek Schuff
https://codereview.chromium.org/597393003/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py File ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py (right): https://codereview.chromium.org/597393003/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py#newcode58 ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py:58: def StandardArch(arch): On 2014/09/24 23:36:46, jvoung wrote: > standardarch ...
6 years, 2 months ago (2014-09-24 23:54:25 UTC) #7
Derek Schuff
About the dependence, according to the ninja dependence browser, the action (pnacl_dyncode_syscall_disabled_test.actions_rules_copies.stamp) depends on gen/sdk/linux_x86/pnacl_newlib/stamp.prep ...
6 years, 2 months ago (2014-09-25 00:01:07 UTC) #8
binji
native_client_sdk lgtm
6 years, 2 months ago (2014-09-25 16:26:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597393003/80001
6 years, 2 months ago (2014-09-25 16:32:28 UTC) #12
Derek Schuff
On 2014/09/25 16:32:28, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-09-25 20:20:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597393003/80001
6 years, 2 months ago (2014-09-25 20:22:24 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001) as c549461e58877f5db52601dcba0b2d7e88d46a53
6 years, 2 months ago (2014-09-25 20:23:20 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 20:23:51 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/24cc138c03e5e58dd3cd1536be0bbcdd6bd9ba49
Cr-Commit-Position: refs/heads/master@{#296781}

Powered by Google App Engine
This is Rietveld 408576698