Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 597313002: GCD Private API: Change hardcoded code to 4 digits not 5. (Closed)

Created:
6 years, 3 months ago by zentaro
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GCD Private API: Change hardcoded code to 4 digits not 5. BUG=417339 Committed: https://crrev.com/154a26e1a53a841fae4ba12d07d0c14fedb63ddb Cr-Commit-Position: refs/heads/master@{#296998}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/local_discovery/privetv3_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/gcd_private/api/session.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/gcd_private/api/wifi_message.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Vitaly Buka (NO REVIEWS)
lgtm I remember from last meeting that other tipes of authentication would have longer codes
6 years, 3 months ago (2014-09-24 21:05:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597313002/1
6 years, 3 months ago (2014-09-24 21:06:35 UTC) #4
zentaro
6 years, 2 months ago (2014-09-24 22:21:09 UTC) #5
zentaro
On 2014/09/24 21:05:29, Vitaly Buka wrote: > lgtm > > I remember from last meeting ...
6 years, 2 months ago (2014-09-24 22:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597313002/1
6 years, 2 months ago (2014-09-24 22:26:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/17254)
6 years, 2 months ago (2014-09-25 01:02:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597313002/1
6 years, 2 months ago (2014-09-26 00:08:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/16365)
6 years, 2 months ago (2014-09-26 03:15:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597313002/20001
6 years, 2 months ago (2014-09-26 18:11:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b298d4f1d0d026e5d004303c8369b4077ed87b20
6 years, 2 months ago (2014-09-26 19:09:03 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:09:40 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/154a26e1a53a841fae4ba12d07d0c14fedb63ddb
Cr-Commit-Position: refs/heads/master@{#296998}

Powered by Google App Engine
This is Rietveld 408576698