Chromium Code Reviews
Help | Chromium Project | Sign in
(551)

Issue 5973004: The CertVerifierJob destructor should delete canceled requests.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
agl, willchan
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

The CertVerifierJob destructor should delete canceled requests.

Add a job to inflight_ only after the job's worker has started
successfully.

R=agl
BUG=63357, 67289
TEST=net_unittests --gtest_filter=CertVerifierTest.CancelRequestThenQuit
should not leak a CertVerifierRequest object under valgrind.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72203

Patch Set 1 #

Patch Set 2 : Add a LOG(ERROR) message #

Total comments: 2

Patch Set 3 : Make willchan's suggested changes #

Patch Set 4 : Sync with ToT #

Patch Set 5 : Sync with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Lint Patch
M net/base/cert_verifier.cc View 1 2 3 4 4 chunks +20 lines, -4 lines 0 comments 0 errors Download
M net/base/cert_verifier_unittest.cc View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
wtc
agl: your dnsrr_resolver.cc code doesn't have this memory leak because the RRResolverJob destructor calls PostAll(). ...
3 years, 4 months ago #1
willchan
LGTM http://codereview.chromium.org/5973004/diff/4001/net/base/cert_verifier.cc File net/base/cert_verifier.cc (right): http://codereview.chromium.org/5973004/diff/4001/net/base/cert_verifier.cc#newcode351 net/base/cert_verifier.cc:351: return ERR_FAILED; Is this ERR_FAILED ok? I don't ...
3 years, 3 months ago #2
agl
3 years, 3 months ago #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6