Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 597293004: MSE: Reduce spurious buffered range discontinuities (Closed)

Created:
6 years, 2 months ago by wolenetz
Modified:
6 years, 2 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MSE: Reduce spurious buffered range discontinuities Includes last frame's duration in the determination of SourceBufferStream's |max_interbuffer_distance_|, to prevent an unusually long segment-ending frame from triggering discontinuity when adjacent buffers are appended. A more correct fix requires StreamParsers to always emit valid frame durations (crbug 351166), and would use them exclusively to determine discontinuity. BUG=351489 R=dalecurtis@chromium.org TEST=No media_unittest, layout, or yt-dash-mse ToT conformance regression. Fixes b/17570928. Committed: https://crrev.com/674907fe07fc1b26b19f41f63ad70bca78665a7b Cr-Commit-Position: refs/heads/master@{#296599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M media/filters/source_buffer_stream.cc View 4 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
wolenetz
PTAL. Thanks!
6 years, 2 months ago (2014-09-24 23:11:27 UTC) #1
DaleCurtis
lgtm, accurate durations can't come soon enough! whatever happened to tbutter's patch?
6 years, 2 months ago (2014-09-25 00:28:05 UTC) #2
wolenetz
On 2014/09/25 00:28:05, DaleCurtis wrote: > lgtm, accurate durations can't come soon enough! whatever happened ...
6 years, 2 months ago (2014-09-25 00:48:43 UTC) #3
wolenetz
On 2014/09/25 00:28:05, DaleCurtis wrote: > lgtm, accurate durations can't come soon enough! whatever happened ...
6 years, 2 months ago (2014-09-25 00:48:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597293004/1
6 years, 2 months ago (2014-09-25 00:49:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b6a27724c923b2c1368b37f1d96bc8cdc14d07c6
6 years, 2 months ago (2014-09-25 00:56:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 00:56:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/674907fe07fc1b26b19f41f63ad70bca78665a7b
Cr-Commit-Position: refs/heads/master@{#296599}

Powered by Google App Engine
This is Rietveld 408576698