DescriptionSuppress lint warning "SdCardPath" for getRawAcceptableDirectories()
The following lint warnings are issued every time when chrome/content
shell is built
../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:365 Do not hardcode "/sdcard/";
use Environment.getExternalStorageDirectory().getPath() instead: SdCardPath [warning]
result.add("/mnt/sdcard/");
~~~~~~~~~~~~~~
../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:366 Do not hardcode "/sdcard/";
use Environment.getExternalStorageDirectory().getPath() instead: SdCardPath [warning]
result.add("/sdcard/");
~~~~~~~~~~
../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:367 Do not hardcode "/data/";
use Context.getFilesDir().getPath() instead: SdCardPath [warning]
result.add("/data/data/" + context.getPackageName() + "/cache/");
As these hardcoded values are required and the warnings here are false positives
which are more explained in https://codereview.chromium.org/561743003/#msg5
BUG=None.
Committed: https://crrev.com/c286ceeed3e28d21603dcb0888109331bab7a7be
Cr-Commit-Position: refs/heads/master@{#296891}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|