Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 597283007: Suppress lint warning "SdCardPath" for getRawAcceptableDirectories() (Closed)

Created:
6 years, 2 months ago by wajahat
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Suppress lint warning "SdCardPath" for getRawAcceptableDirectories() The following lint warnings are issued every time when chrome/content shell is built ../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:365 Do not hardcode "/sdcard/"; use Environment.getExternalStorageDirectory().getPath() instead: SdCardPath [warning] result.add("/mnt/sdcard/"); ~~~~~~~~~~~~~~ ../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:366 Do not hardcode "/sdcard/"; use Environment.getExternalStorageDirectory().getPath() instead: SdCardPath [warning] result.add("/sdcard/"); ~~~~~~~~~~ ../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:367 Do not hardcode "/data/"; use Context.getFilesDir().getPath() instead: SdCardPath [warning] result.add("/data/data/" + context.getPackageName() + "/cache/"); As these hardcoded values are required and the warnings here are false positives which are more explained in https://codereview.chromium.org/561743003/#msg5 BUG=None. Committed: https://crrev.com/c286ceeed3e28d21603dcb0888109331bab7a7be Cr-Commit-Position: refs/heads/master@{#296891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wajahat
Pl. review, Thanks!
6 years, 2 months ago (2014-09-25 15:02:27 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-09-25 17:09:42 UTC) #3
Andrew Hayden (chromium.org)
LGTM as well.
6 years, 2 months ago (2014-09-25 22:14:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597283007/1
6 years, 2 months ago (2014-09-26 04:25:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as aef166811456e4f9c9609dcc5d2a47ddef48ef1e
6 years, 2 months ago (2014-09-26 05:41:19 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 05:41:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c286ceeed3e28d21603dcb0888109331bab7a7be
Cr-Commit-Position: refs/heads/master@{#296891}

Powered by Google App Engine
This is Rietveld 408576698