Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 597253003: Migrate EnhancedBookmarkBridge from component to chrome/browswer (Closed)

Created:
6 years, 3 months ago by Ian Wen
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Migrate EnhancedBookmarkBridge from component folder to chrome/browser folder. EnhancedBookmarkBridge is only used in android platform and should be moved to chrome/browser folder, bacause most bookmark services going through this bridge requires profile. BUG=415774 Committed: https://crrev.com/cb3b0166adacdb4a5d7c9b40dfc1b228b9d6f8c6 Cr-Commit-Position: refs/heads/master@{#296547}

Patch Set 1 #

Patch Set 2 : Add missing files. Sorry :) #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -255 lines) Patch
A + chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks.gypi View 1 2 2 chunks +0 lines, -39 lines 0 comments Download
D components/enhanced_bookmarks/android/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/enhanced_bookmarks/android/component_jni_registrar.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/enhanced_bookmarks/android/component_jni_registrar.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D components/enhanced_bookmarks/android/enhanced_bookmarks_bridge.h View 1 chunk +0 lines, -43 lines 0 comments Download
D components/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D components/enhanced_bookmarks/android/java/src/org/chromium/components/enhancedbookmarks/EnhancedBookmarksBridge.java View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
Ian Wen
6 years, 3 months ago (2014-09-24 19:48:52 UTC) #2
Kibeom Kim (inactive)
Maybe forgot to add new files to this CL?
6 years, 3 months ago (2014-09-24 20:11:44 UTC) #3
Yaron
looks like you forgot to add the new files in this patch. it's only reflecting ...
6 years, 3 months ago (2014-09-24 20:12:49 UTC) #4
Ian Wen
On 2014/09/24 20:12:49, Yaron wrote: > looks like you forgot to add the new files ...
6 years, 3 months ago (2014-09-24 20:39:14 UTC) #5
Kibeom Kim (inactive)
lgtm
6 years, 3 months ago (2014-09-24 21:45:41 UTC) #6
Yaron
lgtm
6 years, 3 months ago (2014-09-24 21:50:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597253003/40001
6 years, 3 months ago (2014-09-24 21:56:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13289)
6 years, 3 months ago (2014-09-24 22:08:26 UTC) #11
Ian Wen
sky@chromium.org: Please review changes in chrome.gyp as you're the owner of it. :) Thanks!
6 years, 3 months ago (2014-09-24 22:13:21 UTC) #13
sky
chrome.gyp LGTM
6 years, 3 months ago (2014-09-24 22:20:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597253003/40001
6 years, 3 months ago (2014-09-24 22:33:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 84e14ce056b5967a16f5a0a8b7f02210cd62cb3f
6 years, 3 months ago (2014-09-24 22:55:03 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 22:55:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb3b0166adacdb4a5d7c9b40dfc1b228b9d6f8c6
Cr-Commit-Position: refs/heads/master@{#296547}

Powered by Google App Engine
This is Rietveld 408576698