Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 59723003: Update size expectations for linux-release/sizes/nacl_helper/nacl_helper (Closed)

Created:
7 years, 1 month ago by kjellander_chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, Mark Seaborn
Visibility:
Public.

Description

Update size expectations for linux-release/sizes/nacl_helper/nacl_helper There's a size regression for the Linux bot in http://build.chromium.org/p/chromium/builders/Linux/builds/44555 PERF_REGRESS: nacl_helper/nacl_helper (0.29%), nacl_helper/nacl_helper (0.29%) Details: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper&rev=232942&checked=core (requires google.com signin). TEST=none BUG=315063 R=phoglund@chromium.org, phoglund@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kjellander_chromium
phoglund@: please have a sanity look. CC: mseaborn@ FYI.
7 years, 1 month ago (2013-11-05 13:08:18 UTC) #1
phoglund_chromium
On 2013/11/05 13:08:18, Henrik Kjellander wrote: > phoglund@: please have a sanity look. > > ...
7 years, 1 month ago (2013-11-05 13:11:38 UTC) #2
kjellander_chromium
On 2013/11/05 13:11:38, phoglund wrote: > On 2013/11/05 13:08:18, Henrik Kjellander wrote: > > phoglund@: ...
7 years, 1 month ago (2013-11-05 13:14:26 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-05 13:21:29 UTC) #4
phoglund1
lgtm
7 years, 1 month ago (2013-11-05 13:23:04 UTC) #5
phoglund_chromium
On 2013/11/05 13:23:04, phoglund1 wrote: > lgtm from correct user: lgtm
7 years, 1 month ago (2013-11-05 13:23:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/59723003/1
7 years, 1 month ago (2013-11-05 13:24:12 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-05 13:30:37 UTC) #8
kjellander_chromium
7 years, 1 month ago (2013-11-05 13:32:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r232954.

Powered by Google App Engine
This is Rietveld 408576698