Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 597113003: [Mac] Re-enable AppShimInteractiveTest.Launch (again). (Closed)

Created:
6 years, 3 months ago by jackhou1
Modified:
6 years, 3 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Re-enable AppShimInteractiveTest.Launch (again). The flakiness only occurs on ASan builds. The test times out because the shim does not successfully launch when the app launches. LSOpenApplication returns procNotFound(-600). It's not clear why this happens, but it could be some interaction with WaitForSingleProcess. Reversing the order of the two test cases fixes the flakiness. BUG=415422 Committed: https://crrev.com/c2a8eb06daad25e87595b64c27540a5d52646e91 Cr-Commit-Position: refs/heads/master@{#296389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M apps/app_shim/app_shim_interactive_uitest_mac.mm View 3 chunks +26 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
6 years, 3 months ago (2014-09-24 10:34:54 UTC) #2
tapted
sweet! lgtm
6 years, 3 months ago (2014-09-24 10:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597113003/1
6 years, 3 months ago (2014-09-24 11:16:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c0abb9a260f5b13aa6a314b633423b304ec63c1e
6 years, 3 months ago (2014-09-24 11:50:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 11:51:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2a8eb06daad25e87595b64c27540a5d52646e91
Cr-Commit-Position: refs/heads/master@{#296389}

Powered by Google App Engine
This is Rietveld 408576698