Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 597083002: Translate NumberDivide/NumberModulus operators to Int32Div, Int32Mod in representation-change.h. (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Translate NumberDivide/NumberModulus operators to Int32Div, Int32Mod in representation-change.h. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24171

Patch Set 1 #

Patch Set 2 : Add multiply. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 3 months ago (2014-09-24 08:29:05 UTC) #1
Michael Starzinger
LGTM.
6 years, 3 months ago (2014-09-24 08:42:43 UTC) #2
titzer
6 years, 3 months ago (2014-09-24 08:49:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 24171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698