Issue 597069: Partial snapshots now working for new context creation. Passes V8 tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597069: Partial snapshots now working for new context creation. Passes V8 tests.... (Closed)

Created:
10 years, 10 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/partial_snapshots/

Visibility:
Public.

Description

Partial snapshots now working for new context creation. Passes V8 tests. TBR=ager Committed: http://code.google.com/p/v8/source/detail?r=3852

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -33 lines)			Patch
M	src/bootstrapper.cc	View	5 chunks	+60 lines, -33 lines	1 comment	Download
M	src/handles.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 10 months ago (2010-02-15 08:36:24 UTC) #2

LGTM

http://codereview.chromium.org/597069/diff/1/4
File src/bootstrapper.cc (right):

http://codereview.chromium.org/597069/diff/1/4#newcode1400
src/bootstrapper.cc:1400: void Genesis::TransferMapsToDeserializedGlobals(
Maps -> Map?
Globals -> Global?

Expand Messages | Collapse Messages