Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 597063002: Revert of DevTools socket tunnel. (Closed)

Created:
6 years, 3 months ago by phoglund_chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@glue
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools socket tunnel. (patchset #11 id:300001 of https://codereview.chromium.org/517233002/) Reason for revert: Fails to compile on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/2163 devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelServerTest.java:291: cannot find symbol symbol: method sleep() sleep(); ^ Original issue's description: > Implementation of DevTools socket tunneling service for remote debugging. > > Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests. > > This CL doesn't care of a few known issues: > 1. Data channel buffer overflow. Data channel automatically closed in this case. > 2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging. > 3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling). > > To keep this CL reasonably simple this issues will be addressed later. > > TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing. > BUG=383418 > > Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1 > Cr-Commit-Position: refs/heads/master@{#296360} TBR=mnaganov@chromium.org,tedchoc@chromium.org,erikwright@chromium.org,serya@chromium.org NOTREECHECKS=true NOTRY=true BUG=383418 Committed: https://crrev.com/cf0900dae461d90af8ed7604da098690d7c744c3 Cr-Commit-Position: refs/heads/master@{#296361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2373 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 chunk +1 line, -2 lines 0 comments Download
M components/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/devtools_bridge.gyp View 1 chunk +0 lines, -42 lines 0 comments Download
D components/devtools_bridge/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/devtools_bridge/README View 1 chunk +0 lines, -2 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/AbstractDataChannel.java View 1 chunk +0 lines, -77 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SocketTunnelBase.java View 1 chunk +0 lines, -396 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SocketTunnelServer.java View 1 chunk +0 lines, -135 lines 0 comments Download
D components/devtools_bridge/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -36 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/LocalTunnelBridgeTest.java View 1 chunk +0 lines, -111 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelServerTest.java View 1 chunk +0 lines, -308 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/DebugActivity.java View 1 chunk +0 lines, -71 lines 0 comments Download
D components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/DebugService.java View 1 chunk +0 lines, -111 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DataChannelMock.java View 1 chunk +0 lines, -135 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DataPipe.java View 1 chunk +0 lines, -79 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/LocalTunnelBridge.java View 1 chunk +0 lines, -190 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/PacketDecoder.java View 1 chunk +0 lines, -67 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/SignalingThreadMock.java View 1 chunk +0 lines, -162 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelClient.java View 1 chunk +0 lines, -303 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/TestUtils.java View 1 chunk +0 lines, -134 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
phoglund_chromium
Created Revert of DevTools socket tunnel.
6 years, 3 months ago (2014-09-24 07:31:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597063002/1
6 years, 3 months ago (2014-09-24 07:32:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 724317f145113ac850a5990d0a160409f7018144
6 years, 3 months ago (2014-09-24 07:33:04 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 07:33:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf0900dae461d90af8ed7604da098690d7c744c3
Cr-Commit-Position: refs/heads/master@{#296361}

Powered by Google App Engine
This is Rietveld 408576698