Move color/gradient/pattern out of StrokeData

Move color/gradient/pattern out of StrokeData

The "other methods" referred to in the documentation of StrokeData, only
use the stroke information that pertain to the "geometry" of the stroke.
This means that m_color/m_gradient/m_pattern are dead weight except for
the use in GraphicsContextState. Move those fields to GCS for better
separation of "geometry" and "ink".

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182610

[fs, 2014-09-24 13:29:25]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, schenney@chromium.org

[fs, 2014-09-24 13:29:26]

If you know of anyone else that could have an opinion on this, please include
them.

[Stephen Chennney, 2014-09-24 14:52:49]

From memory I added this to cope with Canvas or SVG needing to store this or
pass it around. If it turns out you can move the elements around without
breaking anything then I'm fine with it.

[Stephen Chennney, 2014-09-24 14:53:09]

So I'll lgtm because the try bots pass.

[fs, 2014-09-24 15:50:54]

On 2014/09/24 14:52:49, Stephen Chenney wrote:
> From memory I added this to cope with Canvas or SVG needing to store this or
> pass it around. If it turns out you can move the elements around without
> breaking anything then I'm fine with it.

Yeah, the remaining stuff is passed around - mostly to compute stroke bounds I
think - which the fill has no effect on.

[fs, 2014-09-24 15:50:59]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-09-24 15:51:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597053003/1

[commit-bot: I haz the power, 2014-09-24 16:12:20]

Committed patchset #1 (id:1) as 182610