Issue 597033002: Make sure gcc4.6 is not used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597033002: Make sure gcc4.6 is not used (Closed)

Created:
6 years, 3 months ago by Johann

Modified:
6 years, 3 months ago

Reviewers:
Tom Finegan

CC:
chromium-reviews, wwcv, jzern, fgalligan1

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx/

Project:
chromium_deps

Visibility:
Public.

Make sure gcc4.6 is not used Cherry pick https://gerrit.chromium.org/gerrit/#/c/71645/ Intrinsic support in gcc4.6 is poor. Make sure it is not being used. Since the vp8_shortwalsh4x4 function has not previously caused any build failures, this patch should not have any effect in Chromium. TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292105

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -49 lines)			Patch
	M	source/libvpx/vp8/common/arm/neon/loopfilter_neon.c	View		3 chunks	+31 lines, -49 lines	0 comments	Download
	M	source/libvpx/vp8/encoder/arm/neon/vp8_shortwalsh4x4_neon.c	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Johann

Committed patchset #1 (id:1) manually as r292105 (presubmit successful).

6 years, 3 months ago (2014-09-24 03:01:01 UTC) #1

Tom Finegan

6 years, 3 months ago (2014-09-24 05:11:05 UTC) #2

Message was sent while issue was closed.

On 2014/09/24 03:01:01, Johann wrote:
> Committed patchset #1 (id:1) manually as r292105 (presubmit successful).

lgtm