Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 59703011: Reapply r11765 (Closed)

Created:
7 years, 1 month ago by Vyacheslav Egorov (Chromium)
Modified:
7 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Reapply r11765 Add static_cast<int> in HPositionInfo::position to please Win64 build. Improvements in positions handling in optimizing compiler. - When building binary arithmetic op and comparison restore source position of the operation itself before building operation itself after it was changed by building operands. This ensures that position recorded for operation points to the operation token instead of pointing to the rightmost operand; - Add support for recording operands' positions and use these positions when inserting HChange instructions; - When generating hydrogen.cfg emit H-instruction position as BCI (previously 0 was emitted), additionally on every lithium instruction emit annotation pointing to corresponding hydrogen-instruction. This allows to easily reach from deopt_id to lithium instruction and from it to hydrogen instruction and source position. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -9 lines) Patch
M src/hydrogen.cc View 7 chunks +22 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +125 lines, -4 lines 0 comments Download
M src/hydrogen-representation-changes.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
Please take another quick look. Previous attempt to land this CL was reverted due to ...
7 years, 1 month ago (2013-11-18 16:48:27 UTC) #1
danno
lgtm if it actually compiles on x64
7 years, 1 month ago (2013-11-18 17:13:33 UTC) #2
Vyacheslav Egorov (Chromium)
7 years, 1 month ago (2013-11-18 17:24:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698