Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 597003003: X87: Made the detailed reason for deopts mandatory on x87. Unified and improved things. (Closed)

Created:
6 years, 3 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Made the detailed reason for deopts mandatory on x87. Unified and improved things. port r24146. original commit message: Made the detailed reason for deopts mandatory on ia32. Unified and improved things. The number of different detail strings has been reduced a bit without any loss of information. Furthermore, DoubleToI is a bit more informative now. Tiny reason fixes. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -100 lines) Patch
M src/x87/lithium-codegen-x87.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 67 chunks +100 lines, -92 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
weiliang PLTAL. thanks
6 years, 3 months ago (2014-09-24 08:20:14 UTC) #2
Weiliang
lgtm
6 years, 3 months ago (2014-09-24 08:32:33 UTC) #3
Weiliang
Committed as r24169
6 years, 3 months ago (2014-09-24 08:35:15 UTC) #4
Sven Panne
On 2014/09/24 08:35:15, Weiliang wrote: > Committed as r24169 Hmmm, how do you actually commit? ...
6 years, 3 months ago (2014-09-24 11:04:43 UTC) #5
Weiliang
6 years, 3 months ago (2014-09-24 15:23:24 UTC) #6
Message was sent while issue was closed.
On 2014/09/24 11:04:43, Sven Panne wrote:
> On 2014/09/24 08:35:15, Weiliang wrote:
> > Committed as r24169
> 
> Hmmm, how do you actually commit? The CLs from you are not closed
automatically.
> "git cl dcommit" would do it...

Hi Sven, 
Yes, I did it by "git cl dcommit". 
It is a known issue. The x87 CLs reviewed by me are not closed automatically may
be because my account is not "@chromium.com" and unable to close the CLs
automatically which are not created by myself. 

Thanks
-Weiliang

Powered by Google App Engine
This is Rietveld 408576698