Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: google_apis/gaia/ubertoken_fetcher_unittest.cc

Issue 597003002: UbertokenFecther should invalidate access token if it's invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@z359700
Patch Set: Refactor init Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gaia/ubertoken_fetcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gaia/ubertoken_fetcher_unittest.cc
diff --git a/google_apis/gaia/ubertoken_fetcher_unittest.cc b/google_apis/gaia/ubertoken_fetcher_unittest.cc
index 8352ee8cab9566b4a919067e7ea061be93455c75..2676be451c2b8c99ef8dce9d5b82bd497deec1f4 100644
--- a/google_apis/gaia/ubertoken_fetcher_unittest.cc
+++ b/google_apis/gaia/ubertoken_fetcher_unittest.cc
@@ -100,13 +100,72 @@ TEST_F(UbertokenFetcherTest, FailureToGetAccessToken) {
EXPECT_EQ("", consumer_.last_token_);
}
-TEST_F(UbertokenFetcherTest, FailureToGetUberToken) {
+TEST_F(UbertokenFetcherTest, TransientFailureEventualFailure) {
+ fetcher_->StartFetchingToken(kTestAccountId);
+ GoogleServiceAuthError error(GoogleServiceAuthError::CONNECTION_FAILED);
+ fetcher_->OnGetTokenSuccess(NULL, "accessToken", base::Time());
+
+ for (int i = 0; i < UbertokenFetcher::kMaxRetries; ++i) {
+ fetcher_->OnUberAuthTokenFailure(error);
+ EXPECT_EQ(0, consumer_.nb_error_);
+ EXPECT_EQ(0, consumer_.nb_correct_token_);
+ EXPECT_EQ("", consumer_.last_token_);
+ }
+
+ fetcher_->OnUberAuthTokenFailure(error);
+ EXPECT_EQ(1, consumer_.nb_error_);
+ EXPECT_EQ(0, consumer_.nb_correct_token_);
+ EXPECT_EQ("", consumer_.last_token_);
+}
+
+TEST_F(UbertokenFetcherTest, TransientFailureEventualSuccess) {
+ fetcher_->StartFetchingToken(kTestAccountId);
+ GoogleServiceAuthError error(GoogleServiceAuthError::CONNECTION_FAILED);
+ fetcher_->OnGetTokenSuccess(NULL, "accessToken", base::Time());
+
+ for (int i = 0; i < UbertokenFetcher::kMaxRetries; ++i) {
+ fetcher_->OnUberAuthTokenFailure(error);
+ EXPECT_EQ(0, consumer_.nb_error_);
+ EXPECT_EQ(0, consumer_.nb_correct_token_);
+ EXPECT_EQ("", consumer_.last_token_);
+ }
+
+ fetcher_->OnUberAuthTokenSuccess("uberToken");
+ EXPECT_EQ(0, consumer_.nb_error_);
+ EXPECT_EQ(1, consumer_.nb_correct_token_);
+ EXPECT_EQ("uberToken", consumer_.last_token_);
+}
+
+TEST_F(UbertokenFetcherTest, PermanentFailureEventualFailure) {
fetcher_->StartFetchingToken(kTestAccountId);
- GoogleServiceAuthError error(GoogleServiceAuthError::USER_NOT_SIGNED_UP);
fetcher_->OnGetTokenSuccess(NULL, "accessToken", base::Time());
+
+ GoogleServiceAuthError error(GoogleServiceAuthError::USER_NOT_SIGNED_UP);
fetcher_->OnUberAuthTokenFailure(error);
+ EXPECT_EQ(0, consumer_.nb_error_);
+ EXPECT_EQ(0, consumer_.nb_correct_token_);
+ EXPECT_EQ("", consumer_.last_token_);
+ fetcher_->OnGetTokenSuccess(NULL, "accessToken", base::Time());
+ fetcher_->OnUberAuthTokenFailure(error);
EXPECT_EQ(1, consumer_.nb_error_);
EXPECT_EQ(0, consumer_.nb_correct_token_);
EXPECT_EQ("", consumer_.last_token_);
}
+
+TEST_F(UbertokenFetcherTest, PermanentFailureEventualSuccess) {
+ fetcher_->StartFetchingToken(kTestAccountId);
+ GoogleServiceAuthError error(GoogleServiceAuthError::USER_NOT_SIGNED_UP);
+ fetcher_->OnGetTokenSuccess(NULL, "accessToken", base::Time());
+
+ fetcher_->OnUberAuthTokenFailure(error);
+ EXPECT_EQ(0, consumer_.nb_error_);
+ EXPECT_EQ(0, consumer_.nb_correct_token_);
+ EXPECT_EQ("", consumer_.last_token_);
+
+ fetcher_->OnGetTokenSuccess(NULL, "accessToken", base::Time());
+ fetcher_->OnUberAuthTokenSuccess("uberToken");
+ EXPECT_EQ(0, consumer_.nb_error_);
+ EXPECT_EQ(1, consumer_.nb_correct_token_);
+ EXPECT_EQ("uberToken", consumer_.last_token_);
+}
« no previous file with comments | « google_apis/gaia/ubertoken_fetcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698