Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 596963002: Simplifying repro instructions from bisect output for non telemetry cases. (Closed)

Created:
6 years, 3 months ago by RobertoCN
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Simplifying repro instructions from bisect output for non telemetry cases. - Removed redundant output of the test command. - Reduced the number of steps to three and wrote them as succintly as possible. - Added the clarifying notes separately at the end. BUG=404088 Committed: https://crrev.com/39b6931a068a09a41865f1cb43589eb84136da78 Cr-Commit-Position: refs/heads/master@{#296483}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Wording changes based on feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M tools/bisect-perf-regression.py View 1 4 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
RobertoCN
6 years, 3 months ago (2014-09-23 22:51:56 UTC) #2
qyearsley
LGTM with a couple minor suggestions. I'm also in favor of removing more of the ...
6 years, 3 months ago (2014-09-24 03:03:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596963002/20001
6 years, 3 months ago (2014-09-24 18:17:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 93e7a40a627b791e90a56a6fa67e4e7abb028831
6 years, 3 months ago (2014-09-24 19:15:44 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 19:17:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39b6931a068a09a41865f1cb43589eb84136da78
Cr-Commit-Position: refs/heads/master@{#296483}

Powered by Google App Engine
This is Rietveld 408576698