Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 59693007: Get rid of custom code for HTMLDocument.write() / writeln() (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Get rid of custom code for HTMLDocument.write() / writeln() Get rid of custom code for HTMLDocument.write() / writeln() by making the method variadic in Web IDL. Although this is not according to specification, this matches the behavior of our custom code and the one of FF / IE. R=haraken TEST=fast/dom/HTMLDocument/document-write-variadic.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161547

Patch Set 1 #

Patch Set 2 : Move methods to HTMLDocument #

Patch Set 3 : Rebase on master #

Patch Set 4 : Fix test failures #

Total comments: 2

Patch Set 5 : Extend layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -31 lines) Patch
A LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLDocument/document-write-variadic-expected.txt View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp View 1 1 chunk +0 lines, -27 lines 0 comments Download
M Source/core/html/HTMLDocument.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 2 3 2 chunks +22 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-11-07 15:56:24 UTC) #1
haraken
This won't change existing behavior, so LGTM. https://codereview.chromium.org/59693007/diff/110001/LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html File LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html (right): https://codereview.chromium.org/59693007/diff/110001/LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html#newcode11 LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html:11: document.writeln('P', 'A', ...
7 years, 1 month ago (2013-11-07 16:00:18 UTC) #2
Inactive
https://codereview.chromium.org/59693007/diff/110001/LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html File LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html (right): https://codereview.chromium.org/59693007/diff/110001/LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html#newcode11 LayoutTests/fast/dom/HTMLDocument/document-write-variadic.html:11: document.writeln('P', 'A', 'SS'); On 2013/11/07 16:00:19, haraken wrote: > ...
7 years, 1 month ago (2013-11-07 16:21:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/59693007/170001
7 years, 1 month ago (2013-11-07 16:36:18 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 18:57:10 UTC) #5
Message was sent while issue was closed.
Change committed as 161547

Powered by Google App Engine
This is Rietveld 408576698