Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: commit-queue/commit_queue.py

Issue 59693004: CQ: add a timeout for socket operations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | commit-queue/verification/tree_status.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/commit_queue.py
===================================================================
--- commit-queue/commit_queue.py (revision 232827)
+++ commit-queue/commit_queue.py (working copy)
@@ -14,6 +14,7 @@
import os
import shutil
import signal
+import socket
import sys
import tempfile
import time
@@ -146,6 +147,10 @@
def main():
+ # Set a default timeout for sockets. This is critical when talking to remote
+ # services like AppEngine and buildbot.
+ socket.setdefaulttimeout(60.0)
M-A Ruel 2013/11/06 00:48:27 I'd recommend 65 or 70 just in case.
Paweł Hajdan Jr. 2013/11/06 01:00:28 Done.
+
parser = optparse.OptionParser(
description=sys.modules['__main__'].__doc__)
project_choices = projects.supported_projects()
« no previous file with comments | « no previous file | commit-queue/verification/tree_status.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698