Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596923002: Enable a11y audits and fix issues for help page. (Closed)

Created:
6 years, 3 months ago by hcarmona
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable a11y audits and fix issues for help page. BUG=265583 Committed: https://crrev.com/fc731ae71a779acc176240d599f5f5c2df4178ae Cr-Commit-Position: refs/heads/master@{#296747}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/resources/help/help_content.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_browsertest.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hcarmona
Enabled a11y audit and the only issue was the chrome icon. I added empty alt ...
6 years, 3 months ago (2014-09-24 17:09:57 UTC) #2
Dan Beam
lgtm w/nit https://codereview.chromium.org/596923002/diff/1/chrome/browser/ui/webui/help/help_browsertest.js File chrome/browser/ui/webui/help/help_browsertest.js (right): https://codereview.chromium.org/596923002/diff/1/chrome/browser/ui/webui/help/help_browsertest.js#newcode15 chrome/browser/ui/webui/help/help_browsertest.js:15: /** OVERRIDE */ /** @override */
6 years, 3 months ago (2014-09-24 18:39:00 UTC) #3
dmazzoni
lgtm with same nit
6 years, 3 months ago (2014-09-24 19:14:47 UTC) #4
hcarmona
Change OVERRIDE to @override https://codereview.chromium.org/596923002/diff/1/chrome/browser/ui/webui/help/help_browsertest.js File chrome/browser/ui/webui/help/help_browsertest.js (right): https://codereview.chromium.org/596923002/diff/1/chrome/browser/ui/webui/help/help_browsertest.js#newcode15 chrome/browser/ui/webui/help/help_browsertest.js:15: /** OVERRIDE */ On 2014/09/24 ...
6 years, 3 months ago (2014-09-24 20:55:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596923002/20001
6 years, 2 months ago (2014-09-25 17:21:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2f2de8a445003f6294322994553ef982b85c3d2e
6 years, 2 months ago (2014-09-25 18:36:00 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 18:36:50 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fc731ae71a779acc176240d599f5f5c2df4178ae
Cr-Commit-Position: refs/heads/master@{#296747}

Powered by Google App Engine
This is Rietveld 408576698