Status Trays delayed visibility

ash/shelf/shelf_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_layout_manager.h"
 
 #include <algorithm>
 #include <cmath>
 #include <cstring>
 #include <string>
@@ skipping 668 matching lines @@
 
   GetLayer(shelf_)->SetOpacity(target_bounds.opacity);
   shelf_->SetBounds(ScreenUtil::ConvertRectToScreen(
        shelf_->GetNativeView()->parent(),
        target_bounds.shelf_bounds_in_root));
 
   GetLayer(shelf_->status_area_widget())->SetOpacity(
       target_bounds.status_opacity);
 
   // Having a window which is visible but does not have an opacity is an illegal
-  // state. We therefore show / hide the shelf here if required.
-  if (!target_bounds.status_opacity)
+  // state. We therefore hide the shelf here if required.
+  if (!target_bounds.status_opacity) {
     shelf_->status_area_widget()->Hide();
-  else if (target_bounds.status_opacity)
+  } else {
+    // Setting visibility during an animation causes the visibility property to
+    // animate. Override the animation settings to immediately set the

[flackr, 2014/09/23 21:18:40]

I'd prefer to see the scope of the ScopedLayerAnimationSettings above ending
before this call rather than setting up another ScopedLayerAnimationSettings.

[jonross, 2014/09/23 21:34:26]

Done.

+    // visibility property. Opacity will still animate.
+    ui::ScopedLayerAnimationSettings no_duration_show(
+        GetLayer(shelf_->status_area_widget())->GetAnimator());
+    no_duration_show.SetTransitionDuration(base::TimeDelta());
     shelf_->status_area_widget()->Show();
+  }
 
   // TODO(harrym): Once status area widget is a child view of shelf
   // this can be simplified.
   gfx::Rect status_bounds = target_bounds.status_bounds_in_shelf;
   status_bounds.set_x(status_bounds.x() +
                       target_bounds.shelf_bounds_in_root.x());
   status_bounds.set_y(status_bounds.y() +
                       target_bounds.shelf_bounds_in_root.y());
   shelf_->status_area_widget()->SetBounds(
       ScreenUtil::ConvertRectToScreen(
@@ skipping 436 matching lines @@
 
 void ShelfLayoutManager::SessionStateChanged(
     SessionStateDelegate::SessionState state) {
   TargetBounds target_bounds;
   CalculateTargetBounds(state_, &target_bounds);
   UpdateBoundsAndOpacity(target_bounds, true, NULL);
   UpdateVisibilityState();
 }
 
 }  // namespace ash