Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addresses Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html
diff --git a/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html b/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html
new file mode 100644
index 0000000000000000000000000000000000000000..9d67396c26675d844c7d687e152d68698af91456
--- /dev/null
+++ b/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html
@@ -0,0 +1,30 @@
+<style>
+ table { border-collapse: collapse; }
+ td { border: 1px solid #000000; }
+</style>
+<script src="../../resources/check-layout.js"></script>
+<body onload="checkLayout('tr')">
+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=396655">396655</a>. Tables with specific merge cell configuration render with extra height to tr elements.</h4>
+ <p>We have the below table. Because cell A and cell D overlap in the second row, the height of the second row is the 1px difference between A and B and the 1px difference between C and D.</p>
+ <pre>+-----+-----+</pre>
+ <pre>| | B |</pre>
+ <pre>| A +-----+</pre>
+ <pre>| | |</pre>
+ <pre>+-----+ D |</pre>
+ <pre>| C | |</pre>
+ <pre>+-----+-----+</pre>
+ <table style="width: 624px;">
+ <tbody>
+ <tr data-expected-height="32">
+ <td rowspan="2" style="height: 33px;"></td>
+ <td style="height: 32px;"></td>
+ </tr>
+ <tr data-expected-height="1">
+ <td rowspan="2" style="height: 33px;"></td>
+ </tr>
+ <tr data-expected-height="32">
+ <td style="height: 32px;"></td>
+ </tr>
+ </tbody>
+ </table>
+</body>

Powered by Google App Engine
This is Rietveld 408576698