LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html - Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addresses Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells-expected.txt » ('j') | LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

diff --git a/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html b/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

new file mode 100644

index 0000000000000000000000000000000000000000..9d67396c26675d844c7d687e152d68698af91456

--- /dev/null

+++ b/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells.html

@@ -0,0 +1,30 @@

+<style>

+ table { border-collapse: collapse; }

+ td { border: 1px solid #000000; }

+</style>

+<script src="../../resources/check-layout.js"></script>

+<body onload="checkLayout('tr')">

+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=396655">396655</a>. Tables with specific merge cell configuration render with extra height to tr elements.</h4>

+ <p>We have the below table. Because cell A and cell D overlap in the second row, the height of the second row is the 1px difference between A and B and the 1px difference between C and D.</p>

+ <pre>+-----+-----+</pre>

+ <pre>| | B |</pre>

+ <pre>| A +-----+</pre>

+ <pre>| | |</pre>

+ <pre>+-----+ D |</pre>

+ <pre>| C | |</pre>

+ <pre>+-----+-----+</pre>

+ <table style="width: 624px;">

+ <tbody>

+ <tr data-expected-height="32">

+ <td rowspan="2" style="height: 33px;"></td>

+ <td style="height: 32px;"></td>

+ </tr>

+ <tr data-expected-height="1">

+ <td rowspan="2" style="height: 33px;"></td>

+ </tr>

+ <tr data-expected-height="32">

+ <td style="height: 32px;"></td>

+ </tr>

+ </tbody>

+ </table>

+</body>