LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt - Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/platform/linux/fast/table/giantRowspan2-expected.txt

Issue 596823002: Tables with specific merge cell configuration render with extra height to tr elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addresses Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells-expected.txt ('k') | LayoutTests/platform/linux/tables/mozilla/bugs/bug133756-2-expected.png » ('j') | LayoutTests/platform/linux/tables/mozilla/bugs/bug7714-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 layer at (0,0) size 800x600	1 layer at (0,0) size 800x600

2 RenderView at (0,0) size 800x600	2 RenderView at (0,0) size 800x600

3 layer at (0,0) size 800x600	3 layer at (0,0) size 800x600

4 RenderBlock {HTML} at (0,0) size 800x600	4 RenderBlock {HTML} at (0,0) size 800x600

5 RenderBody {BODY} at (8,8) size 784x584	5 RenderBody {BODY} at (8,8) size 784x584

6 RenderTable {TABLE} at (0,0) size 784x84	6 RenderTable {TABLE} at (0,0) size 784x84

7 RenderTableSection {TBODY} at (0,0) size 784x84	7 RenderTableSection {TBODY} at (0,0) size 784x84

8 RenderTableRow {TR} at (0,2) size 784x0	8 RenderTableRow {TR} at (0,2) size 784x1
	dsinclair 2014/12/03 19:25:22 Do we know why this increased in size? Do we know why this increased in size? a.suchit 2014/12/10 04:27:42 Fixed Show quoted text On 2014/12/03 19:25:22, dsinclair wrote: > Do we know why this increased in size? Fixed
9 RenderTableCell {TD} at (2,1) size 780x82 [r=0 c=0 rs=8190 cs=1]	9 RenderTableCell {TD} at (2,1) size 780x82 [r=0 c=0 rs=8190 cs=1]

10 RenderText {#text} at (1,1) size 770x79	10 RenderText {#text} at (1,1) size 770x79

11 text run at (1,1) width 644: "This test succeeds if it does not crash. We implemented a heuristic a while back to prevent giant rowspans. "	11 text run at (1,1) width 644: "This test succeeds if it does not crash. We implemented a heuristic a while back to prevent giant rowspans. "

12 text run at (645,1) width 126: "The heuristic did not,"	12 text run at (645,1) width 126: "The heuristic did not,"

13 text run at (1,21) width 611: "however, fix this case. This rowp san was small enough so that we thought it was okay to allocate, but "	13 text run at (1,21) width 611: "however, fix this case. This rowp san was small enough so that we thought it was okay to allocate, but "

14 text run at (612,21) width 131: "large enough so that it"	14 text run at (612,21) width 131: "large enough so that it"

15 text run at (1,41) width 599: "actually wasn't okay, and we cras hed. Firefox seems to hold 8k as the maximum size for rowspans. "	15 text run at (1,41) width 599: "actually wasn't okay, and we cras hed. Firefox seems to hold 8k as the maximum size for rowspans. "

16 text run at (600,41) width 140: "So this change matches"	16 text run at (600,41) width 140: "So this change matches"

17 text run at (1,61) width 341: "Firefox and clamps all rowspans t o 8k right in the DOM."	17 text run at (1,61) width 341: "Firefox and clamps all rowspans t o 8k right in the DOM."

OLD	NEW