Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 596783005: [Telemetry] Do not run session_restore benchmarks on reference builds. (Closed)

Created:
6 years, 2 months ago by tonyg
Modified:
6 years, 2 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Do not run session_restore benchmarks on reference builds. They were accidentally enabled with the switch to recipes and they don't work because the older builds don't necessarily work with the generated profile. BUG=388885 TBR=dtu@chromium.org Committed: https://crrev.com/6cf222b3094b4a67b1fcc5095fac6f7b8b418a33 Cr-Commit-Position: refs/heads/master@{#296342}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M tools/perf/benchmarks/session_restore.py View 4 chunks +6 lines, -4 lines 1 comment Download
M tools/telemetry/telemetry/test_runner.py View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596783005/1
6 years, 2 months ago (2014-09-24 02:54:45 UTC) #2
dtu
lgtm https://codereview.chromium.org/596783005/diff/1/tools/perf/benchmarks/session_restore.py File tools/perf/benchmarks/session_restore.py (right): https://codereview.chromium.org/596783005/diff/1/tools/perf/benchmarks/session_restore.py#newcode54 tools/perf/benchmarks/session_restore.py:54: @benchmark.Disabled('android', 'linux', 'reference', 'snowleopard') Got a bug number? ...
6 years, 2 months ago (2014-09-24 03:04:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as c871026b3b06ae960d134a854bef704576fba6d6
6 years, 2 months ago (2014-09-24 03:49:47 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 03:50:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cf222b3094b4a67b1fcc5095fac6f7b8b418a33
Cr-Commit-Position: refs/heads/master@{#296342}

Powered by Google App Engine
This is Rietveld 408576698