Chromium Code Reviews

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 596773002: Re-attach plugin renderers in the standard way. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/core/html/HTMLObjectElement.cpp
diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp
index fd8a9d17ba1b9ec55bb54d692eca80682b774513..721e3f1cc308ebecb8c3f1b8d1c93f504ad2fad6 100644
--- a/Source/core/html/HTMLObjectElement.cpp
+++ b/Source/core/html/HTMLObjectElement.cpp
@@ -256,7 +256,7 @@ void HTMLObjectElement::reloadPluginOnAttributeChange(const QualifiedName& name)
}
setNeedsWidgetUpdate(true);
if (needsInvalidation)
- setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::Plugin));
+ lazyReattachIfNeeded();
}
// FIXME: This should be unified with HTMLEmbedElement::updateWidget and
@@ -331,7 +331,7 @@ void HTMLObjectElement::childrenChanged(const ChildrenChange& change)
{
if (inDocument() && !useFallbackContent()) {
setNeedsWidgetUpdate(true);
- setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::Plugin));
+ lazyReattachIfNeeded();
}
HTMLPlugInElement::childrenChanged(change);
}

Powered by Google App Engine