Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: runtime/lib/string_patch.dart

Issue 596763002: Optimize int.parse with a radix. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revert mis-merged patch that got into this CL by mistake. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/js_lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string_patch.dart
diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart
index 1ecdda1ceb30ceed97b3722f71244f6389230559..3dc4733631abf7480c0b748461604d67a159b15f 100644
--- a/runtime/lib/string_patch.dart
+++ b/runtime/lib/string_patch.dart
@@ -57,6 +57,7 @@ class _StringBase {
static String createFromCharCodes(Iterable<int> charCodes,
int start, int end) {
if (charCodes == null) throw new ArgumentError(charCodes);
+ if (start < 0) throw new RangeError.value(start);
// TODO(srdjan): Also skip copying of wide typed arrays.
final ccid = ClassID.getID(charCodes);
bool isOneByteString = false;
@@ -69,15 +70,10 @@ class _StringBase {
charCodes = new List.from(charCodes, growable: false);
}
}
- int codeCount = charCodes.length;
- if (start < 0 || start > codeCount) {
- throw new RangeError.range(start, 0, codeCount);
- }
- if (end == null) {
- end = codeCount;
- } else if (end < start || end > codeCount) {
- throw new RangeError.range(end, start, codeCount);
+ if ((end == null) || (end > charCodes.length)) {
+ end = charCodes.length;
}
+ if (end <= start) return "";
final len = end - start;
if (!isOneByteString) {
for (int i = start; i < end; i++) {
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/js_lib/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698