Android: moves content/ to use long for JNI.

Android: moves content/ to use long for JNI.

BUG=317523
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235815

[bulach, 2013-11-18 16:26:41]

avi:
content/browser/accessibility/browser_accessibility_manager_android.cc
content/browser/speech/speech_recognizer_impl_android.cc
content/shell/android/java/src/org/chromium/content_shell/Shell.java
content/shell/browser/shell_android.cc

yfriedman: everything else :)

thanks!!

https://codereview.chromium.org/59673007/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/59673007/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:937:
public long getNativeContentViewCore() {
this breaks downstream :-/
I have a patch ready and will send to the -mergers mailing list...

after this finishes though, the "right" fix is to expose a java method here,
rather than letting other callers inspect the native side.

[Avi (use Gerrit), 2013-11-18 16:41:46]

LGTM

Have fun and best of luck.

[Yaron, 2013-11-18 17:18:49]

rs lgtm. not sure how to review. I assume you've mostly scripted this?

https://codereview.chromium.org/59673007/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/59673007/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:937:
public long getNativeContentViewCore() {
On 2013/11/18 16:26:42, bulach wrote:
> this breaks downstream :-/
> I have a patch ready and will send to the -mergers mailing list...
> 
> after this finishes though, the "right" fix is to expose a java method here,
> rather than letting other callers inspect the native side.

I partly agree, but not 100% sure. As you can see from the @CalledByNative, I
think this is primarily used from native code when it happens to get a java CVC

[bulach, 2013-11-18 17:38:02]

thanks yaron, avi!

yeah, mostly scripted and validated by bots.. next one is chrome/ and that
should pretty much be it... CQing..

https://codereview.chromium.org/59673007/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/59673007/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:937:
public long getNativeContentViewCore() {
On 2013/11/18 17:18:49, Yaron wrote:
> On 2013/11/18 16:26:42, bulach wrote:
> > this breaks downstream :-/
> > I have a patch ready and will send to the -mergers mailing list...
> > 
> > after this finishes though, the "right" fix is to expose a java method here,
> > rather than letting other callers inspect the native side.
> 
> I partly agree, but not 100% sure. As you can see from the @CalledByNative, I
> think this is primarily used from native code when it happens to get a java
CVC

see the comment on the other side.. :)
at least on that case, it seems the functionality can be implemented as a CVC
java API rather than native..

[commit-bot: I haz the power, 2013-11-18 17:40:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/59673007/1

[commit-bot: I haz the power, 2013-11-18 21:00:24]

Change committed as 235815