Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Issue 596723003: Move override/final to the approved C++11 features section. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
jamesr, Nico, awong
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move override/final to the approved C++11 features section. Discussion thread: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo NOTRY=true Committed: https://crrev.com/5f98d33d5566474db7b31e0960fb09cef0e7c990 Cr-Commit-Position: refs/heads/master@{#296541}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reword per thakis #

Patch Set 3 : Moar edits and links #

Patch Set 4 : Readd the conversion effort text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M styleguide/c++/c++11.html View 1 2 3 5 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
dcheng
Here's an initial draft.
6 years, 3 months ago (2014-09-24 21:43:42 UTC) #2
Nico
lgtm with comments, thanks! https://codereview.chromium.org/596723003/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/596723003/diff/1/styleguide/c++/c++11.html#newcode73 styleguide/c++/c++11.html:73: <td>All uses of the old ...
6 years, 3 months ago (2014-09-24 21:46:14 UTC) #3
dcheng
https://codereview.chromium.org/596723003/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/596723003/diff/1/styleguide/c++/c++11.html#newcode73 styleguide/c++/c++11.html:73: <td>All uses of the old <code>FINAL</code> macro will be ...
6 years, 3 months ago (2014-09-24 21:50:50 UTC) #4
Nico
lgtm; maybe file a bug for the conversion effort. (I liked the "existing OVERRIDES will ...
6 years, 3 months ago (2014-09-24 21:52:28 UTC) #5
jamesr
lgtm2
6 years, 3 months ago (2014-09-24 22:04:54 UTC) #6
dcheng
On 2014/09/24 at 22:04:54, jamesr wrote: > lgtm2 Added the conversion text back and filed ...
6 years, 3 months ago (2014-09-24 22:07:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596723003/60001
6 years, 3 months ago (2014-09-24 22:07:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596723003/60001
6 years, 3 months ago (2014-09-24 22:11:16 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 561ce2b08a061593fac8be44439ff3a1e1e82444
6 years, 3 months ago (2014-09-24 22:12:18 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 22:12:51 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5f98d33d5566474db7b31e0960fb09cef0e7c990
Cr-Commit-Position: refs/heads/master@{#296541}

Powered by Google App Engine
This is Rietveld 408576698