Enabling selection API for input type=<file, color, date, email, number>

Enabling selection API for input type=<file, color, date, email, number>

Source/core/html/forms/BaseDateAndTimeInputType.cpp
Source/core/html/forms/BaseDateAndTimeInputType.h
Source/core/html/forms/TextFieldInputType.cpp
Source/core/html/forms/TextFieldInputType.h
-Added selection API support as these are the base class and all its derived type support selection API.

Source/core/html/forms/ColorInputType.cpp
Source/core/html/forms/ColorInputType.h
Source/core/html/forms/FileInputType.cpp
Source/core/html/forms/FileInputType.h
- Added support for the selection API.

Source/core/html/forms/BaseTextInputType.cpp
Source/core/html/forms/BaseTextInputType.h
Source/core/html/forms/EmailInputType.cpp
Source/core/html/forms/EmailInputType.h
Source/core/html/forms/NumberInputType.cpp
Source/core/html/forms/NumberInputType.h
- Removed supportsSelectionAPI as the base class now includes selection API support.

R=tkent@chromium.org,keishi
BUG=415391
TEST=Updated setrangetext to include new test which does not throw. Number-setrangetext is updated, as number field can except only numbers.

[Habib Virji, 2014-09-23 10:02:58]

Patchset #1 (id:1) has been deleted

[Habib Virji, 2014-09-23 11:13:53]

Implementation of selection API for input type=email, number. They seem to be
working and have included test covering the API.

Selection API for file, color and date will not throw an error but selection API
will not work as HTMLTextFormControl only work for TextFields.

[tkent, 2014-09-23 22:33:49]

This is not a correct implementation.

> Enabling selection API for input type=<file, color, date, email, number>

These types should support select(), but should not support selectionStart,
selectionEnd, selectionDirection, setRangeText(), and setSelectionRange().

https://html.spec.whatwg.org/multipage/forms.html#input-type-attr-summary

[Habib Virji, 2014-09-24 10:12:47]

On 2014/09/23 22:33:49, tkent (high review load) wrote:
> This is not a correct implementation.
> 
> > Enabling selection API for input type=<file, color, date, email, number>
> 
> These types should support select(), but should not support selectionStart,
> selectionEnd, selectionDirection, setRangeText(), and setSelectionRange().
> 
> https://html.spec.whatwg.org/multipage/forms.html#input-type-attr-summary

Had a look, select() is already working for all elements. 
--> select() does not look for supportsSelectionAPI(). Instead uses
Node::canStartSelection(), which allow select if textfield in
HTMLInputElement::canStartSelection(). 
--> All these work, adding selectionStart throws.
---> data:text/html,<input type=date value=2002-10-10 id=date> <script> try {
document.getElementById('date').select();} catch(e) { console.log(e); }</script>
---> data:text/html,<input type=number value=2002 id=num> <script> try {
document.getElementById('num').select(); } catch(e) { console.log(e); }</script>
---> data:text/html,<input type=email value='ex@example.com' id=email> <script>
try { document.getElementById('email').select();} catch(e) { console.log(e);
}</script>
---> data:text/html,<input type=file id=file> <script> try {
document.getElementById('file').select();} catch(e) { console.log(e); }</script>
---> data:text/html,<input type=color value='#00000f' id=color> <script> try {
document.getElementById('color').select();} catch(e) { console.log(e);
}</script>
--> But also this works: data:text/html,<input type=radio value='1' id=radio>
<script> try { document.getElementById('radio').select();} catch(e) {
console.log(e); }</script>

Please suggest what should be course of action, as all required type are already
working in latest Canary.

[tkent, 2014-09-25 05:53:58]

On 2014/09/24 10:12:47, Habib Virji wrote:
> Had a look, select() is already working for all elements. 

Wow, I thought we threw exceptions for non-textfield types.

Then, what we should do:
 * Add a test for select() with type=email, number, date/time, etc.
 * Check behavior of select() with type=radio, etc. on other browsers
   -> if other browsers throw exceptions for these types, we should throw
exceptions too.
   -> Otherwise, we should talk to Hixie and change the specification.

[Habib Virji, 2014-09-25 08:54:15]

Found following behavior:
1. Chrome, Firefox. IE and Opera do not throw error for select() on all input
type (including non text fields, radio, checkbox, button). It does throw error
for selection API.

2. On all browsers select() function, selects all text in input type email. 
3. In Opera and Firefox, selection API() works for input type email.

4. In Chrome and Opera select(), select all number in input type number. 
5. In Opera, selection API works for input type number.

6. Firefox allows using selection API on input type date. While Opera and Chrome
throws exception.
7. Only Chrome, selects radio, checkbox, file and color element. None of the
other browsers does.

Will update this CL with test for select() on all input types. Will update hixie
about above behavior.

[Habib Virji, 2014-10-17 14:55:17]

@tkent: Closing this issue, as no response from Hixie. I was hoping to get
clarification before uploading test for select. As mentioned in comment#6, there
is no exception in any browser but they differ on selection API.

[Habib Virji, 2014-10-17 14:55:20]

@tkent: Closing this issue, as no response from Hixie. I was hoping to get
clarification before uploading test for select. As mentioned in comment#6, there
is no exception in any browser but they differ on selection API.