Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596703004: [turbofan] Add backend support for float32. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
CC:
danno, v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add backend support for float32. LOG=n BUG=v8:3589 TEST=compiler-unittests,cctest R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24179

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 8

Patch Set 3 : Address comments from Ben. #

Patch Set 4 : Temporary changes for float32. #

Total comments: 1

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -140 lines) Patch
M src/arm/assembler-arm.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 chunks +68 lines, -38 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 4 7 chunks +25 lines, -9 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm-unittest.cc View 3 chunks +31 lines, -4 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 2 chunks +10 lines, -12 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/representation-change.h View 1 2 5 chunks +25 lines, -5 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 6 chunks +12 lines, -13 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64-unittest.cc View 1 2 2 chunks +22 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-23 11:57:28 UTC) #1
Benedikt Meurer
PTAL danno: FYI
6 years, 3 months ago (2014-09-23 12:01:23 UTC) #3
Benedikt Meurer
Note that this is only the backend support and the bare minimum for simplified lowering ...
6 years, 3 months ago (2014-09-23 12:03:30 UTC) #4
titzer
lgtm with comments https://codereview.chromium.org/596703004/diff/10031/src/arm64/assembler-arm64.h File src/arm64/assembler-arm64.h (right): https://codereview.chromium.org/596703004/diff/10031/src/arm64/assembler-arm64.h#newcode280 src/arm64/assembler-arm64.h:280: static int NumAllocatableRegistersForTurbofan() { Can we ...
6 years, 3 months ago (2014-09-24 08:53:14 UTC) #5
titzer
https://codereview.chromium.org/596703004/diff/50001/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/596703004/diff/50001/src/compiler/js-typed-lowering.cc#newcode561 src/compiler/js-typed-lowering.cc:561: if (element_access.machine_type == kRepFloat32) { You can move this ...
6 years, 3 months ago (2014-09-24 10:55:23 UTC) #6
Benedikt Meurer
Committed patchset #5 (id:70001) manually as 24179 (presubmit successful).
6 years, 3 months ago (2014-09-24 11:09:02 UTC) #7
Benedikt Meurer
6 years, 3 months ago (2014-09-25 06:09:32 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/596703004/diff/10031/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):

https://codereview.chromium.org/596703004/diff/10031/src/arm64/assembler-arm6...
src/arm64/assembler-arm64.h:280: static int NumAllocatableRegistersForTurbofan()
{
On 2014/09/24 08:53:14, titzer wrote:
> Can we name this something more general? Such as
> NumAllocatableFloat32Registers() or something?

Done.

https://codereview.chromium.org/596703004/diff/10031/src/compiler/arm/code-ge...
File src/compiler/arm/code-generator-arm.cc (right):

https://codereview.chromium.org/596703004/diff/10031/src/compiler/arm/code-ge...
src/compiler/arm/code-generator-arm.cc:25: class ArmOperandConverter FINAL :
public InstructionOperandConverter {
On 2014/09/24 08:53:14, titzer wrote:
> Is the final really necessary? This class is local to this file.

Done.

https://codereview.chromium.org/596703004/diff/10031/src/compiler/ia32/instru...
File src/compiler/ia32/instruction-codes-ia32.h (right):

https://codereview.chromium.org/596703004/diff/10031/src/compiler/ia32/instru...
src/compiler/ia32/instruction-codes-ia32.h:37: V(Cvtss2sd)                     
\
On 2014/09/24 08:53:14, titzer wrote:
> SSE prefix

Done.

https://codereview.chromium.org/596703004/diff/10031/src/compiler/x64/instruc...
File src/compiler/x64/instruction-codes-x64.h (right):

https://codereview.chromium.org/596703004/diff/10031/src/compiler/x64/instruc...
src/compiler/x64/instruction-codes-x64.h:53: V(Cvtss2sd)                      \
On 2014/09/24 08:53:14, titzer wrote:
> SSE prefix

Done.

Powered by Google App Engine
This is Rietveld 408576698