Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 596643003: [x64] three operand imul supports first operand in memory location (Closed)

Created:
6 years, 3 months ago by Weiliang
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[x64] three operand imul supports first operand in memory location R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Weiliang
PTAL
6 years, 3 months ago (2014-09-23 04:53:08 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-23 04:58:52 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-09-25 06:37:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698