Issue 596633002: Do not change state of More/less settings button until printer capabilities are retrieved to avoid …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596633002: Do not change state of More/less settings button until printer capabilities are retrieved to avoid … (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov

Modified:
6 years, 3 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not change state of More/less settings button until printer capabilities are retrieved to avoid unnecessary fade in/out cycles. BUG=415898 Committed: https://crrev.com/1789d42d31ab5435ba8a3a44394448f71b5879f6 Cr-Commit-Position: refs/heads/master@{#296123}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/resources/print_preview/settings/more_settings.js	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596633002/1

6 years, 3 months ago (2014-09-23 00:54:21 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 07dea6eecdb41d4521c096c856449334ffa8424a

6 years, 3 months ago (2014-09-23 01:35:51 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-23 01:36:55 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1789d42d31ab5435ba8a3a44394448f71b5879f6
Cr-Commit-Position: refs/heads/master@{#296123}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages