content/renderer/render_view_impl.cc - Issue 596623002: Fix orientation change callbacks to go through WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 596623002: Fix orientation change callbacks to go through WebLocalFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index eba0382f3453be34ace76c5ecbc5423274f14451..daa895c7aac6bd464c1f0a71c704540267187977 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3128,7 +3128,8 @@ void RenderViewImpl::OnOrientationChange() {

observers_,

OrientationChangeEvent());

- webview()->mainFrame()->sendOrientationChangeEvent();

+ DCHECK(webview()->mainFrame()->isWebLocalFrame());

jam 2014/09/23 05:17:13 nit: no need, if it's null the next line will be j

dcheng 2014/09/23 05:24:34 Done.

+ webview()->mainFrame()->toWebLocalFrame()->sendOrientationChangeEvent();

}

void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,

« no previous file with comments | « no previous file | content/shell/renderer/test_runner/mock_screen_orientation_client.h » ('j') | content/shell/renderer/webkit_test_runner.cc » ('J')