Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 596613002: Remove content dependencies from content settings providers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: shutdown fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
index 7e32cb78fc4bd0df96d8ce1f5a32192fc4ce0105..6ec195133076568de9897f0958793243a0a87802 100644
--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
@@ -7,7 +7,6 @@
#include "base/auto_reset.h"
#include "base/command_line.h"
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
#include "base/prefs/default_pref_store.h"
#include "base/prefs/overlay_user_pref_store.h"
#include "base/prefs/pref_change_registrar.h"
@@ -28,12 +27,10 @@
#include "chrome/test/base/testing_pref_service_syncable.h"
#include "chrome/test/base/testing_profile.h"
#include "components/pref_registry/pref_registry_syncable.h"
-#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
using ::testing::_;
-using content::BrowserThread;
namespace content_settings {
@@ -92,18 +89,7 @@ class DeadlockCheckerObserver {
DISALLOW_COPY_AND_ASSIGN(DeadlockCheckerObserver);
};
-class PrefProviderTest : public testing::Test {
- public:
- PrefProviderTest() : ui_thread_(
- BrowserThread::UI, &message_loop_) {
- }
-
- protected:
- base::MessageLoop message_loop_;
- content::TestBrowserThread ui_thread_;
-};
-
-TEST_F(PrefProviderTest, Observer) {
+TEST(PrefProviderTest, Observer) {
TestingProfile profile;
PrefProvider pref_content_settings_provider(profile.GetPrefs(), false);
@@ -130,7 +116,7 @@ TEST_F(PrefProviderTest, Observer) {
// Test for regression in which the PrefProvider modified the user pref store
// of the OTR unintentionally: http://crbug.com/74466.
-TEST_F(PrefProviderTest, Incognito) {
+TEST(PrefProviderTest, Incognito) {
PersistentPrefStore* user_prefs = new TestingPrefStore();
OverlayUserPrefStore* otr_user_prefs =
new OverlayUserPrefStore(user_prefs);
@@ -197,7 +183,7 @@ TEST_F(PrefProviderTest, Incognito) {
pref_content_settings_provider_incognito.ShutdownOnUIThread();
}
-TEST_F(PrefProviderTest, GetContentSettingsValue) {
+TEST(PrefProviderTest, GetContentSettingsValue) {
TestingProfile testing_profile;
PrefProvider provider(testing_profile.GetPrefs(), false);
@@ -259,7 +245,7 @@ TEST_F(PrefProviderTest, GetContentSettingsValue) {
provider.ShutdownOnUIThread();
}
-TEST_F(PrefProviderTest, Patterns) {
+TEST(PrefProviderTest, Patterns) {
TestingProfile testing_profile;
PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(),
false);
@@ -348,7 +334,7 @@ TEST_F(PrefProviderTest, Patterns) {
pref_content_settings_provider.ShutdownOnUIThread();
}
-TEST_F(PrefProviderTest, ResourceIdentifier) {
+TEST(PrefProviderTest, ResourceIdentifier) {
TestingProfile testing_profile;
PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(),
false);
@@ -384,7 +370,7 @@ TEST_F(PrefProviderTest, ResourceIdentifier) {
pref_content_settings_provider.ShutdownOnUIThread();
}
-TEST_F(PrefProviderTest, AutoSubmitCertificateContentSetting) {
+TEST(PrefProviderTest, AutoSubmitCertificateContentSetting) {
TestingProfile profile;
TestingPrefServiceSyncable* prefs = profile.GetTestingPrefService();
GURL primary_url("https://www.example.com");
@@ -418,7 +404,7 @@ TEST_F(PrefProviderTest, AutoSubmitCertificateContentSetting) {
}
// http://crosbug.com/17760
-TEST_F(PrefProviderTest, Deadlock) {
+TEST(PrefProviderTest, Deadlock) {
TestingPrefServiceSyncable prefs;
PrefProvider::RegisterProfilePrefs(prefs.registry());
@@ -441,7 +427,7 @@ TEST_F(PrefProviderTest, Deadlock) {
provider.ShutdownOnUIThread();
}
-TEST_F(PrefProviderTest, LastUsage) {
+TEST(PrefProviderTest, LastUsage) {
TestingProfile testing_profile;
PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(),
false);

Powered by Google App Engine
This is Rietveld 408576698