Remove content dependencies from content settings providers.

chrome/browser/content_settings/content_settings_default_provider.cc

Index: chrome/browser/content_settings/content_settings_default_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_default_provider.cc b/chrome/browser/content_settings/content_settings_default_provider.cc
index 7e8023612cd2a3806b4455f56648d29f94a0db58..a21a0def4670807d6b742794d353fcaf5ea37a6d 100644
--- a/chrome/browser/content_settings/content_settings_default_provider.cc
+++ b/chrome/browser/content_settings/content_settings_default_provider.cc
@@ -9,26 +9,19 @@
 
 #include "base/auto_reset.h"
 #include "base/basictypes.h"
+#include "base/bind.h"

[vabr (Chromium), 2014/09/23 07:51:00]

Why did you include this?
(Also in other files.)

[Jun Mukai, 2014/09/23 20:48:44]

Bind is used below (line 173 in this file).  It was implicitly included through
browser_thread.h (browser_thread.h -> base/task_runner_util.h -> base/bind.h)

[vabr (Chromium), 2014/09/24 09:56:39]

Thanks for explanation, makes sense.

 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
-#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/content_settings_utils.h"
 #include "chrome/common/pref_names.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "components/pref_registry/pref_registry_syncable.h"
-#include "content/public/browser/browser_thread.h"
-#include "content/public/browser/notification_details.h"
-#include "content/public/browser/notification_source.h"
-#include "content/public/browser/user_metrics.h"
 #include "url/gurl.h"
 
-using base::UserMetricsAction;
-using content::BrowserThread;
-
 namespace {
 
 // The default setting for each content type.
@@ -191,7 +184,7 @@ bool DefaultProvider::SetWebsiteSetting(
     ContentSettingsType content_type,
     const ResourceIdentifier& resource_identifier,
     base::Value* in_value) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK(CalledOnValidThread());
   DCHECK(prefs_);
 
   // Ignore non default settings
@@ -270,7 +263,7 @@ void DefaultProvider::ClearAllContentSettingsRules(
 }
 
 void DefaultProvider::ShutdownOnUIThread() {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK(CalledOnValidThread());
   DCHECK(prefs_);
   RemoveAllObservers();
   pref_change_registrar_.RemoveAll();
@@ -278,7 +271,7 @@ void DefaultProvider::ShutdownOnUIThread() {
 }
 
 void DefaultProvider::OnPreferenceChanged(const std::string& name) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK(CalledOnValidThread());
   if (updating_preferences_)
     return;