Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: chrome/browser/content_settings/content_settings_policy_provider.cc

Issue 596613002: Remove content dependencies from content settings providers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser_tests fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/content_settings/content_settings_policy_provider.h" 5 #include "chrome/browser/content_settings/content_settings_policy_provider.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h"
10 #include "base/json/json_reader.h" 11 #include "base/json/json_reader.h"
11 #include "base/prefs/pref_service.h" 12 #include "base/prefs/pref_service.h"
12 #include "base/values.h" 13 #include "base/values.h"
13 #include "chrome/browser/content_settings/content_settings_utils.h" 14 #include "chrome/browser/content_settings/content_settings_utils.h"
14 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
15 #include "components/content_settings/core/browser/content_settings_rule.h" 16 #include "components/content_settings/core/browser/content_settings_rule.h"
16 #include "components/content_settings/core/common/content_settings_pattern.h" 17 #include "components/content_settings/core/common/content_settings_pattern.h"
17 #include "components/pref_registry/pref_registry_syncable.h" 18 #include "components/pref_registry/pref_registry_syncable.h"
18 #include "content/public/browser/browser_thread.h"
19
20 using content::BrowserThread;
21 19
22 namespace { 20 namespace {
23 21
24 // The preferences used to manage ContentSettingsTypes. 22 // The preferences used to manage ContentSettingsTypes.
25 const char* kPrefToManageType[] = { 23 const char* kPrefToManageType[] = {
26 prefs::kManagedDefaultCookiesSetting, 24 prefs::kManagedDefaultCookiesSetting,
27 prefs::kManagedDefaultImagesSetting, 25 prefs::kManagedDefaultImagesSetting,
28 prefs::kManagedDefaultJavaScriptSetting, 26 prefs::kManagedDefaultJavaScriptSetting,
29 prefs::kManagedDefaultPluginsSetting, 27 prefs::kManagedDefaultPluginsSetting,
30 prefs::kManagedDefaultPopupsSetting, 28 prefs::kManagedDefaultPopupsSetting,
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 const ResourceIdentifier& resource_identifier, 434 const ResourceIdentifier& resource_identifier,
437 base::Value* value) { 435 base::Value* value) {
438 return false; 436 return false;
439 } 437 }
440 438
441 void PolicyProvider::ClearAllContentSettingsRules( 439 void PolicyProvider::ClearAllContentSettingsRules(
442 ContentSettingsType content_type) { 440 ContentSettingsType content_type) {
443 } 441 }
444 442
445 void PolicyProvider::ShutdownOnUIThread() { 443 void PolicyProvider::ShutdownOnUIThread() {
446 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 444 DCHECK(CalledOnValidThread());
447 RemoveAllObservers(); 445 RemoveAllObservers();
448 if (!prefs_) 446 if (!prefs_)
449 return; 447 return;
450 pref_change_registrar_.RemoveAll(); 448 pref_change_registrar_.RemoveAll();
451 prefs_ = NULL; 449 prefs_ = NULL;
452 } 450 }
453 451
454 void PolicyProvider::OnPreferenceChanged(const std::string& name) { 452 void PolicyProvider::OnPreferenceChanged(const std::string& name) {
455 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 453 DCHECK(CalledOnValidThread());
456 454
457 if (name == prefs::kManagedDefaultCookiesSetting) { 455 if (name == prefs::kManagedDefaultCookiesSetting) {
458 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES); 456 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES);
459 } else if (name == prefs::kManagedDefaultImagesSetting) { 457 } else if (name == prefs::kManagedDefaultImagesSetting) {
460 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_IMAGES); 458 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_IMAGES);
461 } else if (name == prefs::kManagedDefaultJavaScriptSetting) { 459 } else if (name == prefs::kManagedDefaultJavaScriptSetting) {
462 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_JAVASCRIPT); 460 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_JAVASCRIPT);
463 } else if (name == prefs::kManagedDefaultPluginsSetting) { 461 } else if (name == prefs::kManagedDefaultPluginsSetting) {
464 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_PLUGINS); 462 UpdateManagedDefaultSetting(CONTENT_SETTINGS_TYPE_PLUGINS);
465 } else if (name == prefs::kManagedDefaultPopupsSetting) { 463 } else if (name == prefs::kManagedDefaultPopupsSetting) {
(...skipping 22 matching lines...) Expand all
488 ReadManagedDefaultSettings(); 486 ReadManagedDefaultSettings();
489 } 487 }
490 488
491 NotifyObservers(ContentSettingsPattern(), 489 NotifyObservers(ContentSettingsPattern(),
492 ContentSettingsPattern(), 490 ContentSettingsPattern(),
493 CONTENT_SETTINGS_TYPE_DEFAULT, 491 CONTENT_SETTINGS_TYPE_DEFAULT,
494 std::string()); 492 std::string());
495 } 493 }
496 494
497 } // namespace content_settings 495 } // namespace content_settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698