Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596563003: Move painting code from RenderDetailsMarker into DetailsMarkerPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Move painting code from RenderDetailsMarker into DetailsMarkerPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182469

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -79 lines) Patch
M Source/core/core.gypi View 1 1 chunk +4 lines, -3 lines 0 comments Download
A Source/core/paint/DetailsMarkerPainter.h View 1 chunk +30 lines, -0 lines 0 comments Download
A Source/core/paint/DetailsMarkerPainter.cpp View 1 chunk +93 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderDetailsMarker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderDetailsMarker.cpp View 3 chunks +2 lines, -74 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chrishtr
6 years, 2 months ago (2014-09-22 23:31:37 UTC) #2
pdr.
On 2014/09/22 23:31:37, chrishtr wrote: LGTM
6 years, 2 months ago (2014-09-22 23:39:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596563003/1
6 years, 2 months ago (2014-09-22 23:40:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/11283)
6 years, 2 months ago (2014-09-22 23:49:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596563003/20001
6 years, 2 months ago (2014-09-23 05:28:29 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 06:35:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182469

Powered by Google App Engine
This is Rietveld 408576698