Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596523002: Make PepperTryCatch hold a reference on PepperPluginInstanceImpl (Closed)

Created:
6 years, 3 months ago by dmichael (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
bbudge, raymes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make PepperTryCatch hold a reference on PepperPluginInstanceImpl BUG=416311 Committed: https://crrev.com/4c929f39322d01f407c5469a84ed5109f379ebe6 Cr-Commit-Position: refs/heads/master@{#296055}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix for review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/renderer/pepper/pepper_try_catch.h View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dmichael (off chromium)
Please see bug for more context.
6 years, 3 months ago (2014-09-22 18:53:11 UTC) #2
bbudge
LGTM 1 comment https://codereview.chromium.org/596523002/diff/1/content/renderer/pepper/pepper_try_catch.h File content/renderer/pepper/pepper_try_catch.h (right): https://codereview.chromium.org/596523002/diff/1/content/renderer/pepper/pepper_try_catch.h#newcode43 content/renderer/pepper/pepper_try_catch.h:43: // shouldn't keep the instance around ...
6 years, 3 months ago (2014-09-22 19:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596523002/20001
6 years, 3 months ago (2014-09-22 20:10:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6f1eedae4be308474e3eaaf3a4c26736550e8d89
6 years, 3 months ago (2014-09-22 21:10:22 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4c929f39322d01f407c5469a84ed5109f379ebe6 Cr-Commit-Position: refs/heads/master@{#296055}
6 years, 3 months ago (2014-09-22 21:11:03 UTC) #7
raymes
6 years, 3 months ago (2014-09-22 23:33:25 UTC) #8
Message was sent while issue was closed. 
On 2014/09/22 21:11:03, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/4c929f39322d01f407c5469a84ed5109f379ebe6
> Cr-Commit-Position: refs/heads/master@{#296055}

Thanks a lot for landing this guys! lgtm

Powered by Google App Engine
This is Rietveld 408576698