Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 596493002: Add actiivity in factory (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add actiivity in factory rather than each caller adds them. BUG=None R=sadrul@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2903f33784712aa48e18006a6bca60dd284afd97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M athena/activity/activity_manager_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M athena/content/content_activity_factory.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M athena/content/web_activity.cc View 1 chunk +1 line, -0 lines 0 comments Download
M athena/extensions/athena_app_delegate_base.cc View 2 chunks +1 line, -2 lines 0 comments Download
M athena/extensions/chrome/extensions_delegate_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M athena/home/home_card_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M athena/main/placeholder.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M athena/main/url_search_provider.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M athena/test/sample_activity_factory.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
oshima
6 years, 3 months ago (2014-09-22 17:55:53 UTC) #2
sadrul
LGTM Would adding the Activity to the ActivityManager from the Activity constructor work?
6 years, 3 months ago (2014-09-23 14:44:20 UTC) #3
oshima
On 2014/09/23 14:44:20, sadrul wrote: > LGTM > > Would adding the Activity to the ...
6 years, 3 months ago (2014-09-23 16:51:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596493002/1
6 years, 3 months ago (2014-09-23 17:59:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2903f33784712aa48e18006a6bca60dd284afd97 Cr-Commit-Position: refs/heads/master@{#296213}
6 years, 3 months ago (2014-09-23 20:19:20 UTC) #9
oshima
6 years, 3 months ago (2014-09-23 20:19:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2903f33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698