Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 596413002: Correct glyph with non-bmp from typeface on Mac. (Closed)

Created:
6 years, 3 months ago by bungeman-skia
Modified:
6 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, eae, Dominik Röttsches
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Correct glyph with non-bmp from typeface on Mac. CTFontGetGlyphsForChars puts the glyph id at the index of the lead surrogate as is documented in comments, but the code is looking at the index of the trail surrogate. BUG=skia:2960 Committed: https://skia.googlesource.com/skia/+/7b09aab7130c174c6a2dd4becedbddaa6cf7945d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FontHostTest.cpp View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
The testing for this sort of thing is mostly around SkScalerContext::generateCharToGlyph instead of SkTypeface::onCharsToGlyphs (since ...
6 years, 3 months ago (2014-09-24 17:42:20 UTC) #2
mtklein
lgtm
6 years, 3 months ago (2014-09-24 17:49:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596413002/1
6 years, 3 months ago (2014-09-24 17:50:31 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 18:04:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 7b09aab7130c174c6a2dd4becedbddaa6cf7945d

Powered by Google App Engine
This is Rietveld 408576698