Shorten live ranges of argument subexpressions.

src/ia32/lithium-codegen-ia32.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2372 matching lines @@
 
   int arity = instr->arity();
   Handle<Code> ic = StubCache::ComputeCallInitialize(arity, NOT_IN_LOOP);
   __ mov(ecx, instr->name());
   CallCode(ic, RelocInfo::CODE_TARGET_CONTEXT, instr);
   __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
 }
 
 
 void LCodeGen::DoCallKnownGlobal(LCallKnownGlobal* instr) {
+  ASSERT(ToRegister(instr->input()).is(eax));
   ASSERT(ToRegister(instr->result()).is(eax));
-  __ mov(edi, instr->target());
-  CallKnownFunction(instr->target(), instr->arity(), instr);
+
+  // The receiver slot in the outgoing arguments holds the global object,
+  // because that's what the unoptimized code expects if we deoptimize the
+  // argument subexpressions.  Patch it to the global receiver before making
+  // the call.
+  int arity = instr->arity();  // Arity does not include receiver.
+  __ mov(Operand(esp, arity * kPointerSize), eax);

[fschneider, 2010/12/20 16:13:02]

It would be nice to avoid patching in the global receiver.

+
+  Handle<JSFunction> target = instr->target();
+  __ mov(edi, target);
+  CallKnownFunction(target, arity, instr);
 }
 
 
 void LCodeGen::DoCallNew(LCallNew* instr) {
   ASSERT(ToRegister(instr->input()).is(edi));
   ASSERT(ToRegister(instr->result()).is(eax));
 
   Handle<Code> builtin(Builtins::builtin(Builtins::JSConstructCall));
   __ Set(eax, Immediate(instr->arity()));
   CallCode(builtin, RelocInfo::CONSTRUCT_CALL, instr);
@@ skipping 837 matching lines @@
   ASSERT(!environment->HasBeenRegistered());
   RegisterEnvironmentForDeoptimization(environment);
   ASSERT(osr_pc_offset_ == -1);
   osr_pc_offset_ = masm()->pc_offset();
 }
 
 
 #undef __
 
 } }  // namespace v8::internal