Shorten live ranges of argument subexpressions.

src/hydrogen-instructions.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 503 matching lines @@
 
   // Verify that instructions that may have side-effects are followed
   // by a simulate instruction.
   if (HasSideEffects() && !IsOsrEntry()) {
     ASSERT(next()->IsSimulate());
   }
 }
 #endif
 
 
-HCall::HCall(int count) : arguments_(Zone::NewArray<HValue*>(count), count) {
-  for (int i = 0; i < count; ++i) arguments_[i] = NULL;
+HCall::HCall(int argument_count) : argument_count_(argument_count) {
   set_representation(Representation::Tagged());
   SetFlagMask(AllSideEffects());
 }
 
 
 void HCall::PrintDataTo(StringStream* stream) const {
-  stream->Add("(");
-  for (int i = 0; i < arguments_.length(); ++i) {
-    if (i != 0) stream->Add(", ");
-    arguments_.at(i)->PrintNameTo(stream);
-  }
-  stream->Add(")");
+  stream->Add("#%d", argument_count());
 }
 
 
 void HClassOfTest::PrintDataTo(StringStream* stream) const {
   stream->Add("class_of_test(");
   value()->PrintTo(stream);
   stream->Add(", \"%o\")", *class_name());
 }
 
 
 void HAccessArgumentsAt::PrintDataTo(StringStream* stream) const {
   arguments()->PrintNameTo(stream);
   stream->Add("[");
   index()->PrintNameTo(stream);
   stream->Add("], length ");
   length()->PrintNameTo(stream);
 }
 
 
-void HCall::SetArgumentAt(int index, HPushArgument* push_argument) {
-  push_argument->set_argument_index(index);
-  SetOperandAt(index, push_argument);
-}
-
-
 void HCallConstantFunction::PrintDataTo(StringStream* stream) const {
   if (IsApplyFunction()) {
     stream->Add("SPECIAL function: apply");
   } else {
     stream->Add("%s", *(function()->shared()->DebugName()->ToCString()));
   }
   HCall::PrintDataTo(stream);
 }
 
 
@@ skipping 82 matching lines @@
 }
 
 
 void HTypeofIs::PrintDataTo(StringStream* stream) const {
   value()->PrintNameTo(stream);
   stream->Add(" == ");
   stream->Add(type_literal_->ToAsciiVector());
 }
 
 
-void HPushArgument::PrintDataTo(StringStream* stream) const {
-  HUnaryOperation::PrintDataTo(stream);
-  if (argument_index() != -1) {
-    stream->Add(" [%d]", argument_index_);
-  }
-}
-
-
 void HChange::PrintDataTo(StringStream* stream) const {
   HUnaryOperation::PrintDataTo(stream);
   stream->Add(" %s to %s", from_.Mnemonic(), to_.Mnemonic());
 
   if (CanTruncateToInt32()) stream->Add(" truncating-int32");
   if (CheckFlag(kBailoutOnMinusZero)) stream->Add(" -0?");
 }
 
 
 HCheckInstanceType* HCheckInstanceType::NewIsJSObjectOrJSFunction(
@@ skipping 11 matching lines @@
 
 void HCheckFunction::PrintDataTo(StringStream* stream) const {
   value()->PrintNameTo(stream);
   stream->Add(" %p", *target());
 }
 
 
 void HCallKeyed::PrintDataTo(StringStream* stream) const {
   stream->Add("[");
   key()->PrintNameTo(stream);
-  stream->Add("](");
-  for (int i = 1; i < arguments_.length(); ++i) {
-    if (i != 1) stream->Add(", ");
-    arguments_.at(i)->PrintNameTo(stream);
-  }
-  stream->Add(")");
+  stream->Add("]");
 }
 
 
 void HCallNamed::PrintDataTo(StringStream* stream) const {
   SmartPointer<char> name_string = name()->ToCString();
   stream->Add("%s ", *name_string);
   HCall::PrintDataTo(stream);
 }
 
 
 void HCallGlobal::PrintDataTo(StringStream* stream) const {
   SmartPointer<char> name_string = name()->ToCString();
   stream->Add("%s ", *name_string);
   HCall::PrintDataTo(stream);
 }
 
 
+void HCallKnownGlobal::PrintDataTo(StringStream* stream) const {
+  receiver()->PrintNameTo(stream);
+}
+
+
+void HCallNew::PrintDataTo(StringStream* stream) const {
+  constructor()->PrintNameTo(stream);
+}
+
+
 void HCallRuntime::PrintDataTo(StringStream* stream) const {
   SmartPointer<char> name_string = name()->ToCString();
   stream->Add("%s ", *name_string);
   HCall::PrintDataTo(stream);
 }
 
+
 void HCallStub::PrintDataTo(StringStream* stream) const {
   stream->Add("%s(%d)",
               CodeStub::MajorName(major_key_, false),
               argument_count_);
 }
 
 
 Range* HValue::InferRange() {
   if (representation().IsTagged()) {
     // Tagged values are always in int32 range when converted to integer,
@@ skipping 694 matching lines @@
 
 
 void HCheckPrototypeMaps::Verify() const {
   HInstruction::Verify();
   ASSERT(HasNoUses());
 }
 
 #endif
 
 } }  // namespace v8::internal