Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 596373002: Fix Ozone build (Closed)

Created:
6 years, 3 months ago by dnicoara
Modified:
6 years, 3 months ago
Reviewers:
jam, luken, sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Ozone build Ozone compiles with USE_AURA=1 TOOLKIT_VIEWS=0 which cases compile errors due to missing member functions ShowDisambiguationPopup and HideDisambiguationPopup. BUG=none TBR=jam@chromium.org Committed: https://crrev.com/572a998c62e405ae1baff5bd331e532d1941fba9 Cr-Commit-Position: refs/heads/master@{#296506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
dnicoara
PTAL jam@ for owners luken@ fyi This is a followup to https://codereview.chromium.org/351683002 which introduced the ...
6 years, 3 months ago (2014-09-24 17:32:09 UTC) #2
luken
On 2014/09/24 17:32:09, dnicoara wrote: > PTAL > > jam@ for owners > luken@ fyi ...
6 years, 3 months ago (2014-09-24 17:48:20 UTC) #3
dnicoara
On 2014/09/24 17:48:20, luken wrote: > On 2014/09/24 17:32:09, dnicoara wrote: > > PTAL > ...
6 years, 3 months ago (2014-09-24 17:53:30 UTC) #4
sky
LGTM
6 years, 3 months ago (2014-09-24 19:26:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596373002/1
6 years, 3 months ago (2014-09-24 20:16:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4a036bcdaeedc089482733525f21647e6ae99d5c
6 years, 3 months ago (2014-09-24 20:22:04 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 20:23:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/572a998c62e405ae1baff5bd331e532d1941fba9
Cr-Commit-Position: refs/heads/master@{#296506}

Powered by Google App Engine
This is Rietveld 408576698