Issue 596363002: [Android] Offset smart clip rect output when there is a change in viewport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596363002: [Android] Offset smart clip rect output when there is a change in viewport (Closed)

Created:
6 years, 3 months ago by jdduke (slow)

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

[Android] Offset smart clip rect output when there is a change in viewport Smart clip rect output needs to be offsetted when there is a change in viewport, e.g., when location bar is shown. BUG=414597 TEST=verified by OEM that this fixes the bug TBR=tedchoc@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9f641d8e668705c2d77dd4ef6646b10eb619c85a

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

jdduke (slow)

6 years, 3 months ago (2014-09-24 15:38:42 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 9f641d8 (presubmit successful).