Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 596343003: PPAPI: Fix raymes's review comments I missed (Closed)

Created:
6 years, 2 months ago by dmichael (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Fix raymes's review comments I missed from https://codereview.chromium.org/589213003/ BUG=401761 TBR=raymes@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/renderer/pepper/message_channel.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596343003/1
6 years, 2 months ago (2014-09-24 16:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596343003/1
6 years, 2 months ago (2014-09-24 23:13:50 UTC) #6
raymes
lgtm
6 years, 2 months ago (2014-09-24 23:52:46 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/renderer/pepper/message_channel.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-09-25 00:05:59 UTC) #9
dmichael (off chromium)
6 years, 2 months ago (2014-09-25 15:40:36 UTC) #10
https://codereview.chromium.org/589213003/ got reverted and this didn't apply.

I'll just put it in the re-land of https://codereview.chromium.org/589213003/
 and close this CL.

Powered by Google App Engine
This is Rietveld 408576698