Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 596343002: cc: Null-check the result of GrContext::wrapBackendTexture. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, senorblanco, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Null-check the result of GrContext::wrapBackendTexture. This function can return NULL if it fails to attach a stencil buffer, or if it fails to allocate a GrGLTexture object. R=enne@chromium.org BUG=416795 Committed: https://crrev.com/3af9f604e16585ae3a8e858631f394108df5f4ce Cr-Commit-Position: refs/heads/master@{#296425}

Patch Set 1 #

Patch Set 2 : null: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M cc/output/gl_renderer.cc View 1 5 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
danakj
6 years, 3 months ago (2014-09-24 14:58:51 UTC) #1
Stephen White
Makes sense to me, but maybe Brian should take a look.
6 years, 3 months ago (2014-09-24 15:00:22 UTC) #4
danakj
On Wed, Sep 24, 2014 at 11:00 AM, <senorblanco@chromium.org> wrote: > Makes sense to me, ...
6 years, 3 months ago (2014-09-24 15:02:37 UTC) #5
bsalomon
lgtm
6 years, 3 months ago (2014-09-24 15:12:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596343002/20001
6 years, 3 months ago (2014-09-24 15:14:00 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-24 15:14:02 UTC) #10
Stephen White
LGTM
6 years, 3 months ago (2014-09-24 15:15:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596343002/20001
6 years, 3 months ago (2014-09-24 15:17:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 78b6599f34c85a2cf34d33744178defd27a8532b
6 years, 3 months ago (2014-09-24 15:50:52 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 15:51:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3af9f604e16585ae3a8e858631f394108df5f4ce
Cr-Commit-Position: refs/heads/master@{#296425}

Powered by Google App Engine
This is Rietveld 408576698