src/core/SkXfermode.cpp - Issue 596333002: Fix SkXfermode deserialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkXfermode.cpp

Issue 596333002: Fix SkXfermode deserialization. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add comment per review. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkXfermode.cpp

diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp

index 443aa194055861c89c3fadf74ca3c143629bd544..8a3218fcbd0087f0d264f5550412c8a6171acf9c 100644

--- a/src/core/SkXfermode.cpp

+++ b/src/core/SkXfermode.cpp

@@ -1258,7 +1258,7 @@ SkProcCoeffXfermode::SkProcCoeffXfermode(SkReadBuffer& buffer) : INHERITED(buffe

SkFlattenable* SkProcCoeffXfermode::CreateProc(SkReadBuffer& buffer) {

uint32_t mode32 = buffer.read32();

- if (!buffer.validate(mode32 >= SK_ARRAY_COUNT(gProcCoeffs))) {

+ if (!buffer.validate(mode32 < SK_ARRAY_COUNT(gProcCoeffs))) {

return NULL;

}

return SkXfermode::Create((SkXfermode::Mode)mode32);

« no previous file with comments | « no previous file | tests/SerializationTest.cpp » ('j') | no next file with comments »