Fix SkXfermode deserialization.

Fix SkXfermode deserialization.

Validation was failing due to an inverted test condition.

BUG=417266
Committed: https://skia.googlesource.com/skia/+/0f7197bc0ddbe6c61732d6fe69df86bdba00a060

[Stephen White, 2014-09-24 14:47:11]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2014-09-24 14:47:20]

reed@: PTAL. Thanks!

[reed1, 2014-09-24 15:58:46]

good catch. can we simplify the test?

https://codereview.chromium.org/596333002/diff/1/tests/SerializationTest.cpp
File tests/SerializationTest.cpp (right):

https://codereview.chromium.org/596333002/diff/1/tests/SerializationTest.cpp#...
tests/SerializationTest.cpp:264: static void
TestXfermodeSerialization(skiatest::Reporter* reporter) {
Ensuring that this list matches the enum in SkXfermode seems hard.
Do you think just a loop that ends with <= kLastMode would works just as well
(with an escape-hatch for SrcOver)?

[Stephen White, 2014-09-24 16:38:39]

https://codereview.chromium.org/596333002/diff/1/tests/SerializationTest.cpp
File tests/SerializationTest.cpp (right):

https://codereview.chromium.org/596333002/diff/1/tests/SerializationTest.cpp#...
tests/SerializationTest.cpp:264: static void
TestXfermodeSerialization(skiatest::Reporter* reporter) {
On 2014/09/24 15:58:46, reed1 wrote:
> Ensuring that this list matches the enum in SkXfermode seems hard.
> Do you think just a loop that ends with <= kLastMode would works just as well
> (with an escape-hatch for SrcOver)?

Good idea. Done.

[reed1, 2014-09-24 17:09:16]

lgtm w/ request for comment where we skip srcover

https://codereview.chromium.org/596333002/diff/40001/tests/SerializationTest.cpp
File tests/SerializationTest.cpp (right):

https://codereview.chromium.org/596333002/diff/40001/tests/SerializationTest....
tests/SerializationTest.cpp:266: if (i == SkXfermode::kSrcOver_Mode) {
// skip srcover, as it is allowed to return NULL from Create

[Stephen White, 2014-09-24 18:01:39]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2014-09-24 18:02:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596333002/60001

[commit-bot: I haz the power, 2014-09-24 18:09:41]

Committed patchset #4 (id:60001) as 0f7197bc0ddbe6c61732d6fe69df86bdba00a060